Open
Conversation
remykusters
approved these changes
May 17, 2021
Member
remykusters
left a comment
remykusters
left a comment
There was a problem hiding this comment.
I like the change, it's clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
I took a stab at simplifying the library. It's not there yet, but we're getting closer I think. Basically I split it into two functions: deriv_features and build_features. Deriv_features calculates all derivatives (now using autodiff but we can try and collocate and then use finite diff) and build_features takes in the prediction and the derivatives to build theta, the feature matrix. Main motivation behind this is that you can use build_features for for classical methods (haven't tested yet) so if you build a custom library you can use it with classical methods as well.
Let me know what you think?