feat(Composed Modal): L3-10837 add min-widths to ComposedModal#784
Open
feat(Composed Modal): L3-10837 add min-widths to ComposedModal#784
Conversation
✅ Deploy Preview for phillips-seldon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
🚀 Storybook preview is ready. • Preview: https://68b9f094608b90f3cfec5a06-urgrzlipbh.chromatic.com/ |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds minimum width constraints to the ComposedModal component to improve its responsiveness and ensure consistent sizing across different screen sizes. The changes align with the Figma design specifications for the modal component.
Key Changes
- Set default
min-widthof35remfor desktop viewports - Added responsive
min-widthof22.5remfor mobile/tablet viewports (below 961px) - Removed explicit
width: 95vwproperty and its corresponding media query override, simplifying the sizing logic to rely onmax-widthandmin-widthconstraints
12 tasks
smarks8
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket
L3-10837
Screenshots

Figma link
Figma
Summary
Adds
min-widthto the ComposedModal, for both mobile and desktop screens sizesChange List (describe the changes made to the files)
This pull request updates the modal sizing logic in the
ComposedModalcomponent to improve its responsiveness and ensure more consistent minimum widths across different screen sizes. The main focus is on refining the minimum width and removing redundant width settings.Modal sizing and responsiveness updates:
min-widthof35remfor.composed-modal, replacing the previous value of0, to ensure a reasonable minimum modal size on larger screens.$breakpoint-mdto set themin-widthto22.5rem, improving usability on medium and small devices.width: 95vw;property and the media query that setwidth: auto;for larger screens, simplifying the width logic and relying onmax-widthandmin-widthfor sizing. [1] [2]Things to look for during review
feat(scope): ...if aminorrelease should be triggered.phillipsclass prefix are using the prefix variabledata-testidattribute.New Components
index.tsfilecomponentStyles.scssfile.