Conversation
✅ Deploy Preview for phillips-seldon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
🚀 Storybook preview is ready. • Preview: https://68b9f094608b90f3cfec5a06-izlqadgmga.chromatic.com/ |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces two new semantic typography tokens (badgeSmall and badgeMedium) for badges to ensure consistent styling across the design system. The changes add proper typography tokens specifically for badge elements, replacing the previous practice of using generic label variants for badges.
Changes:
- Added
badgeSmallandbadgeMediumtypography variants with responsive font sizes - Updated
ObjectTileto usebadgeSmallfor "No Reserve" badges - Updated
SaleCardto usebadgeMediumfor status badges
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/components/Text/types.ts |
Added badgeSmall and badgeMedium to the TextVariants enum |
src/scss/_vars.scss |
Defined SCSS variables for badge font sizes and added badge tokens to the token list |
src/scss/_type.scss |
Implemented mixins for badge typography using label-styles with appropriate font sizes |
src/design/type-tokens/_text-showcase.scss |
Added showcase styles for badge tokens |
src/design/type-tokens/type-tokens.mdx |
Added documentation section displaying badge token specifications and usage |
src/patterns/ObjectTile/ObjectTile.tsx |
Changed badge from labelSmall to badgeSmall variant |
src/patterns/SaleCard/SaleCard.tsx |
Changed badge from labelSmall to badgeMedium variant |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket
L3-10719
Screenshots

Figma link
Figma Link - Badge Type
Summary
We need new semantic text tokens for badges to ensure consistency across Seldon and Remix. We’ll introduce two semantic tokens:
badgeSmall for No Reserve
badgeMedium for Sale Card status
Change List (describe the changes made to the files)
This pull request introduces new typography variants for badges, updating both the codebase and documentation to support and showcase
badgeSmallandbadgeMediumstyles. The changes ensure badges have dedicated font sizes and styling tokens across TypeScript, SCSS, and Storybook documentation, and update their usage in key components.Typography system updates
badgeSmallandbadgeMediumto theTextVariantsenum intypes.tsto enable usage throughout the codebase._vars.scss, and integrated these tokens into the main typography mixins and token lists. [1] [2] [3] [4] [5]_text-showcase.scssfile to include badge-specific styles for showcase and documentation purposes.Component usage updates
ObjectTileandSaleCardcomponents to use the new badge variants (badgeSmallandbadgeMedium) for their badge text elements, replacing the previous label variants. [1] [2]Documentation enhancements
These updates collectively ensure that badge text styling is consistent, maintainable, and well-documented across the design system.
Acceptance Test (how to verify the PR)
Regression Test
Evidence of testing
Things to look for during review
feat(scope): ...if aminorrelease should be triggered.phillipsclass prefix are using the prefix variabledata-testidattribute.New Components
index.tsfilecomponentStyles.scssfile.