Open
Conversation
Contributor
thibaultzanini
commented
Jan 8, 2026
thibaultzanini
commented
- Fix 'proficency' → 'proficiency' throughout codebase (14+ instances)
- Fix 'PersonalSkillAssesssmentDescriptor' → 'PersonalSkillAssessmentDescriptor' (triple s)
- Fix 'roleHoldeProficiency' → 'roleHolderProficiency'
- Fix 'Expections' → 'Expectations'
- Fix 'profiule' → 'profile'
- Fix incomplete description in proficiency-scale.mjson
- Fix incorrect inverse property in personal-skill-assessment.mjson (strengthAssessments → skillAssessments)
- Rename proficency-.mjson files to proficiency-.mjson
- Update all file references to renamed files
- Fix 'proficency' → 'proficiency' throughout codebase (14+ instances) - Fix 'PersonalSkillAssesssmentDescriptor' → 'PersonalSkillAssessmentDescriptor' (triple s) - Fix 'roleHoldeProficiency' → 'roleHolderProficiency' - Fix 'Expections' → 'Expectations' - Fix 'profiule' → 'profile' - Fix incomplete description in proficiency-scale.mjson - Fix incorrect inverse property in personal-skill-assessment.mjson (strengthAssessments → skillAssessments) - Rename proficency-*.mjson files to proficiency-*.mjson - Update all file references to renamed files
There was a problem hiding this comment.
Pull request overview
This pull request fixes numerous spelling errors throughout the codebase, primarily correcting "proficency" to "proficiency" (14+ instances), fixing other typos like "PersonalSkillAssesssmentDescriptor" (triple s) to "PersonalSkillAssessmentDescriptor", "roleHoldeProficiency" to "roleHolderProficiency", and correcting an incorrect inverse property reference. The .mjson descriptor files were also renamed from proficency-.mjson to proficiency-.mjson, and all file references were updated accordingly.
- Corrects spelling of "proficiency" throughout JavaScript and MJSON files
- Fixes class and property descriptor names with typos
- Renames .mjson files and updates internal references
- Corrects inverse property relationship in personal-skill-assessment.mjson
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| data/model/party/profile/skill.js | Renamed property from proficencyScale to proficiencyScale |
| data/model/party/profile/proficiency-scale.mjson | Updated class name, descriptions, file references, and internal object references from proficency to proficiency |
| data/model/party/profile/proficiency-level.mjson | Updated class name, descriptions, file references, and internal object references from proficency to proficiency |
| data/model/party/profile/professional-profile.mjson | Fixed PersonalSkillAssesssmentDescriptor typo (triple s) |
| data/model/party/profile/personal-strength.js | Renamed property from proficencyScale to proficiencyScale |
| data/model/party/profile/personal-strength-assessment.js | Renamed property from proficencyScale to proficiencyScale |
| data/model/party/profile/personal-skill-assessment.mjson | Fixed multiple proficency→proficiency typos and corrected inverse property from strengthAssessments to skillAssessments |
| data/model/job-role-skill-importance-scale.mjson | Updated descriptor references and property names from proficency to proficiency |
| data/model/job-role-skill-importance-level.mjson | Updated descriptor references and descriptions from proficency to proficiency |
| data/model/job-role-skill-expectation.mjson | Fixed roleHoldeProficiency→roleHolderProficiency, updated descriptor references, and corrected Expections→Expectations in description |
| data/model/job-role-skill-expectation.js | Renamed property from proficencyScale to proficiencyScale |
| data/model.mjson | Updated ProficencyScale and ProficencyLevel references to correct spelling |
| data/instance/party/profile/proficiency-scale.mjson | Fixed prototype reference path typo (profiule→profile) and updated scale name reference |
Comments suppressed due to low confidence (5)
data/model/party/profile/proficiency-level.mjson:17
- The module reference has been updated to './proficiency-level', but the actual JavaScript file is still named 'proficency-level.js' (with the typo). This will cause a module loading error. Either the .js file needs to be renamed to 'proficiency-level.js', or this reference should remain as './proficency-level' until the .js file is also renamed.
data/model/party/profile/proficiency-level.mjson:25 - The object reference has been updated to './proficiency-level', but the actual JavaScript file is still named 'proficency-level.js' (with the typo). This will cause a module loading error. Either the .js file needs to be renamed to 'proficiency-level.js', or this reference should remain as './proficency-level' until the .js file is also renamed.
data/instance/party/profile/proficiency-scale.mjson:9 - The prototype reference has been updated to 'data/model/party/profile/proficiency-scale', but the actual JavaScript file is still named 'proficency-scale.js' (with the typo). This will cause a module loading error. Either the .js file needs to be renamed to 'proficiency-scale.js', or this reference should remain as 'data/model/party/profile/proficency-scale' until the .js file is also renamed.
data/model/party/profile/proficiency-scale.mjson:16 - The module reference has been updated to './proficiency-scale', but the actual JavaScript file is still named 'proficency-scale.js' (with the typo). This will cause a module loading error. Either the .js file needs to be renamed to 'proficiency-scale.js', or this reference should remain as './proficency-scale' until the .js file is also renamed.
data/model/party/profile/proficiency-scale.mjson:24 - The object reference has been updated to './proficiency-scale', but the actual JavaScript file is still named 'proficency-scale.js' (with the typo). This will cause a module loading error. Either the .js file needs to be renamed to 'proficiency-scale.js', or this reference should remain as './proficency-scale' until the .js file is also renamed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "ProficencyScale": { | ||
| "object": "./model/party/profile/proficency-scale.mjson" | ||
| "ProficiencyScale": { | ||
| "object": "./model/party/profile/proficiency-scale.mjson" |
There was a problem hiding this comment.
The object reference path has been updated to './model/party/profile/proficiency-scale.mjson', which correctly points to the renamed .mjson file. However, that .mjson file internally references './proficiency-scale.js' which doesn't exist (the file is still named 'proficency-scale.js'). This will cause module loading errors when this descriptor is used.
Suggested change
| "object": "./model/party/profile/proficiency-scale.mjson" | |
| "object": "./model/party/profile/proficency-scale.mjson" |
| "ProficencyLevel": { | ||
| "object": "./model/party/profile/proficency-level.mjson" | ||
| "ProficiencyLevel": { | ||
| "object": "./model/party/profile/proficiency-level.mjson" |
There was a problem hiding this comment.
The object reference path has been updated to './model/party/profile/proficiency-level.mjson', which correctly points to the renamed .mjson file. However, that .mjson file internally references './proficiency-level.js' which doesn't exist (the file is still named 'proficency-level.js'). This will cause module loading errors when this descriptor is used.
thibaultzanini
commented
Jan 8, 2026
| }, | ||
| "0199f8df-c7b4-7cdc-b68e-78042e80fa30": { | ||
| "prototype": "data/model/party/profiule/proficency-scale", | ||
| "prototype": "data/model/party/profile/proficiency-scale", |
| "name": { | ||
| "en": { | ||
| "US": "Four Level Proficency Scale" | ||
| "US": "Four Level Proficiency Scale" |
Contributor
Author
There was a problem hiding this comment.
@marchant There is a typo Proficency is not a valid English word
| { | ||
| "@": "selfAssessedProficencyLevel" | ||
| "@": "selfAssessedProficiencyLevel" | ||
| }, |
| "@": "PersonDescriptor" | ||
| }, | ||
| "inversePropertyName": "strengthAssessments" | ||
| "inversePropertyName": "skillAssessments" |
| value: undefined | ||
| }, | ||
| proficencyScale: { | ||
| proficiencyScale: { |
| value: undefined | ||
| }, | ||
| proficencyScale: { | ||
| proficiencyScale: { |
| value: undefined | ||
| }, | ||
| proficencyScale: { | ||
| proficiencyScale: { |
| @@ -2,26 +2,26 @@ | |||
| "root": { | |||
| "prototype": "mod/core/meta/module-object-descriptor", | |||
| "values": { | |||
| }, | ||
| "ProficencyScale": { | ||
| "object": "./model/party/profile/proficency-scale.mjson" | ||
| "ProficiencyScale": { |
| @@ -38,17 +38,17 @@ | |||
| "isMandatory": true | |||
| } | |||
| }, | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.