Validate MJSON configuration files and inheritance#65
Open
thibaultzanini wants to merge 2 commits intomainfrom
Open
Validate MJSON configuration files and inheritance#65thibaultzanini wants to merge 2 commits intomainfrom
thibaultzanini wants to merge 2 commits intomainfrom
Conversation
Comprehensive audit of 8 MJSON files in data/model/questionnaire/: - Validated JSON syntax, inheritance chains, and property descriptors - Identified 2 minor issues: orphaned property in questionnaire-question.mjson and unused definition in variable.mjson - 6 files are fully valid with correct structure
- questionnaire-question.mjson: Add missing notes property to propertyDescriptors - variable.mjson: Remove unused variablePrototype definition
There was a problem hiding this comment.
Pull request overview
This PR validates MJSON configuration files in the data/model/questionnaire directory and fixes two identified issues: an orphaned property definition and an unused definition.
- Added validation report documenting 8 MJSON files
- Fixed orphaned
notesproperty in questionnaire-question.mjson by adding it to propertyDescriptors array - Removed unused
variablePrototypedefinition from variable.mjson
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mjson-validation-report.md | New validation report documenting the analysis of 8 MJSON configuration files and identifying 2 issues |
| data/model/questionnaire/variable.mjson | Removed unused variablePrototype definition (lines 26-28) |
| data/model/questionnaire/questionnaire-question.mjson | Added notes property reference to propertyDescriptors array to expose the previously orphaned property definition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thibaultzanini
commented
Jan 8, 2026
| "variable": { | ||
| "object": "./variable" | ||
| }, | ||
| "variablePrototype": { |
| {"@": "possibleAnswers"}, | ||
| {"@": "respondentQuestionnaireAnswers"} | ||
| {"@": "respondentQuestionnaireAnswers"}, | ||
| {"@": "notes"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.