Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the service with the latest changes from the pilot repository, updating dependencies, modernizing code syntax, and removing deprecated Vault configuration.
- Updates Python version constraint from
^3.9to>=3.10,<3.11and service version from 2.2.6 to 2.2.9 - Removes Vault configuration code and related dependencies
- Modernizes type hints to use Python 3.10+ union syntax (
X | Noneinstead ofOptional[X])
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates service version to 2.2.9 and restricts Python to 3.10.x |
| app/config.py | Removes Vault configuration functions and updates version string |
| app/commons/notification_service/models.py | Modernizes type hints to PEP 604 union syntax and converts string formatting to f-string |
| app/commons/notification_service/client.py | Updates type hints to use modern union syntax |
| app/main.py | Capitalizes first letter of docstring |
| Dockerfile | Updates base image from python-3.10.12-v2 to python-3.10.14-v1 |
| .pre-commit-config.yaml | Updates docformatter from v1.7.5 to v1.7.7 |
| .github/workflows/hdc-pipeline.yml | Adds new HDC CI/CD pipeline workflow with test, build, and deploy jobs |
| .env.example | Removes Vault-related environment variable examples |
| tests/init.py, app/routers/init.py, app/routers/v1/init.py, app/resources/init.py, app/models/init.py, app/init.py, app/commons/pipeline_ops/init.py, migrations/versions/396048c16b59_adding_copy_request_tables.py | Removes trailing blank lines for code style consistency |
| app/resources/error_handler.py | Adjusts blank line placement for PEP 8 compliance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the latest changes from the pilot repo.