Skip to content

IEBH-353: Sync with the latest changes#10

Merged
vmoshynskyi merged 1 commit intomainfrom
IEBH-353
Nov 4, 2025
Merged

IEBH-353: Sync with the latest changes#10
vmoshynskyi merged 1 commit intomainfrom
IEBH-353

Conversation

@vmoshynskyi
Copy link
Member

Add the latest changes from the pilot repo.

@vmoshynskyi vmoshynskyi requested a review from Copilot November 4, 2025 13:24
@vmoshynskyi vmoshynskyi self-assigned this Nov 4, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependencies and modernizes Python type hints to use Python 3.10+ syntax. Key changes include upgrading Pydantic from version 1.8.2 to 1.10.19, removing vault configuration support, and adopting the new union type syntax (X | Y instead of Optional[X] and Union[X, Y]).

  • Upgraded Pydantic from 1.8.2 to 1.10.19 to support newer Python features
  • Replaced typing.Optional and typing.Union imports with modern Python 3.10+ union syntax (X | Y)
  • Removed vault-related configuration and dependencies
  • Simplified byte string encoding calls using modern syntax

Reviewed Changes

Copilot reviewed 33 out of 34 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pyproject.toml Bumped Pydantic from 1.8.2 to 1.10.19 and version from 2.2.25 to 2.2.28
poetry.lock Updated lock file with Pydantic 1.10.19 hashes and typing-extensions requirement
app/config.py Removed vault configuration classes, updated type hints to use modern union syntax
app/services/data_providers/ldap_client.py Simplified byte string encoding calls and removed redundant 'utf-8' arguments
tests/conftest.py Changed byte string literal to use b'' prefix instead of .encode()
app/services/notifier_services/email_service.py Updated type hints to modern union syntax, removed unused imports
app/resources/keycloak_api/ops_admin.py Updated type hints to modern union syntax
app/models/*.py Updated type hints and capitalized docstrings
app/components/keycloak/client.py Imported Mapping from collections.abc and updated type hints
migrations/versions/*.py Removed blank lines after license headers
migrations/env.py Reformatted docstring to fit within line limits
Dockerfile Updated base image and removed timezone configuration
Jenkinsfile Removed entire Jenkins pipeline file
.github/workflows/hdc-pipeline.yml Added new GitHub Actions CI/CD workflow
.pre-commit-config.yaml Updated docformatter to v1.7.7
.env.example Removed vault-related environment variables

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py0884%89–90, 92, 96, 98–101
__main__.py040%7, 9, 11–12
config.py00100% 
logger.py00100% 
commons/notification
   __init__.py00100% 
commons/project_services
   __init__.py00100% 
commons/psql_services
   invitation.py0865%18–21, 31–34
   ldap_id.py0940%16–24
   permissions.py012414%21–24, 26–28, 33–38, 43–44, 47–52, 57–63, 68–79, 84–89, 94–99, 107–116, 121, 129–134, 136–137, 139–146, 151–158, 163–167, 174–182, 186–193, 197–200, 202–212
   user_event.py01379%33, 40–43, 64–67, 77, 80–82
components
   __init__.py00100% 
   exceptions.py01374%23, 30, 37, 42, 53, 57, 61, 69, 73, 77, 85, 89, 93
components/identity
   __init__.py00100% 
   crud.py00100% 
   dependencies.py0183%17
components/keycloak
   __init__.py00100% 
   client.py0297%33, 96
   dependencies.py0471%24–25, 33, 35
   models.py00100% 
models
   api_response.py0292%34–35
   base_models.py0386%33–35
   default_roles.py00100% 
   events.py0392%36, 124, 131
   external.py00100% 
   invitation.py0589%22, 44, 47, 56, 62
   ops_admin.py00100% 
   ops_user.py00100% 
   permissions.py01775%46, 63–64, 74–77, 79, 81–82, 94–95, 102–104, 106–107
   permissions_schema.py00100% 
   sql_events.py00100% 
   sql_invitation.py00100% 
   sql_ldap_id.py0477%21–24
   user_account_management.py00100% 
   user_create.py00100% 
resources
   error_handler.py0195%33
resources/keycloak_api
   ops_admin.py05553%86–88, 146, 154–158, 160, 183, 191–196, 214, 232–233, 241–243, 245, 260–261, 269–272, 289–296, 316, 356–359, 372–374, 388–389, 404, 418, 421–425
   ops_user.py01142%15–16, 22–24, 27–28, 31–32, 35–36
routers
   api_registry.py00100% 
   ops_admin.py05178%89, 104–106, 160–165, 199–200, 205–207, 236–238, 262–265, 267–272, 274, 293–301, 303–307, 309, 384–386, 390, 399–401
   ops_user.py02586%87–89, 128–130, 237–239, 242, 290–292, 362, 367, 369, 371, 393–395, 399, 401, 440–442
   user_account_management.py02183%71–76, 108–110, 140–142, 144–146, 182–184, 209, 234–235
   vm_account_management.py03162%108–110, 127, 129–130, 132, 141, 143–144, 152–153, 162, 164, 166–167, 172–174, 183, 185–189, 196, 198, 200, 202–204
routers/api_user_create
   api_user_create.py00100% 
routers/event
   event.py00100% 
routers/health
   health.py02143%23–28, 30–42, 52–53
routers/invitation
   external.py00100% 
   invitation.py02285%73, 77–86, 134–135, 142, 190–193, 223–226
   invitation_notify.py0294%46, 57
routers/permissions
   __init__.py00100% 
   casbin.py00100% 
   default_roles.py0681%44–49
   dependencies.py0473%25–27, 29
   permission_metadata.py02052%41, 43–46, 51–54, 61–67, 76–77, 83–84
   permissions.py01750%37, 39–40, 42–48, 50–55, 57
services/data_providers
   __init__.py00100% 
   freeipa_client.py06548%34–37, 40–50, 63–65, 72–73, 104–105, 107, 114–117, 127, 131–135, 169–176, 188–192, 199–206, 209, 213–215, 221–227
   identity_client.py00100% 
   keycloak_client.py02568%16, 20–21, 28–31, 76–77, 82–86, 92–93, 116–117, 144–145, 148–152
   ldap_client.py07042%22–33, 46–48, 104–106, 108–116, 131–132, 134–136, 138–140, 153–154, 159–167, 188–189, 195–200, 202–206, 216–220, 230–231, 240–241, 262–263
services/notifier_services
   email_service.py0384%45, 48, 59
TOTAL267467074% 

@vmoshynskyi vmoshynskyi merged commit 6b2f3ca into main Nov 4, 2025
15 of 16 checks passed
@vmoshynskyi vmoshynskyi deleted the IEBH-353 branch November 4, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant