Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies and modernizes Python type hints to use Python 3.10+ syntax. Key changes include upgrading Pydantic from version 1.8.2 to 1.10.19, removing vault configuration support, and adopting the new union type syntax (X | Y instead of Optional[X] and Union[X, Y]).
- Upgraded Pydantic from 1.8.2 to 1.10.19 to support newer Python features
- Replaced
typing.Optionalandtyping.Unionimports with modern Python 3.10+ union syntax (X | Y) - Removed vault-related configuration and dependencies
- Simplified byte string encoding calls using modern syntax
Reviewed Changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Bumped Pydantic from 1.8.2 to 1.10.19 and version from 2.2.25 to 2.2.28 |
| poetry.lock | Updated lock file with Pydantic 1.10.19 hashes and typing-extensions requirement |
| app/config.py | Removed vault configuration classes, updated type hints to use modern union syntax |
| app/services/data_providers/ldap_client.py | Simplified byte string encoding calls and removed redundant 'utf-8' arguments |
| tests/conftest.py | Changed byte string literal to use b'' prefix instead of .encode() |
| app/services/notifier_services/email_service.py | Updated type hints to modern union syntax, removed unused imports |
| app/resources/keycloak_api/ops_admin.py | Updated type hints to modern union syntax |
| app/models/*.py | Updated type hints and capitalized docstrings |
| app/components/keycloak/client.py | Imported Mapping from collections.abc and updated type hints |
| migrations/versions/*.py | Removed blank lines after license headers |
| migrations/env.py | Reformatted docstring to fit within line limits |
| Dockerfile | Updated base image and removed timezone configuration |
| Jenkinsfile | Removed entire Jenkins pipeline file |
| .github/workflows/hdc-pipeline.yml | Added new GitHub Actions CI/CD workflow |
| .pre-commit-config.yaml | Updated docformatter to v1.7.7 |
| .env.example | Removed vault-related environment variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the latest changes from the pilot repo.