Merged
Conversation
Member
vmoshynskyi
commented
Nov 4, 2025
- Add audit logs.
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies and adds comprehensive audit logging throughout the authentication service. The changes include upgrading Python to 3.10+, updating critical packages like requests and pilot-platform-common, and implementing structured audit logging for authentication and user management operations.
- Upgraded Python from ^3.9 to >=3.10,<3.11 to align with dependency requirements
- Updated critical dependencies including requests (2.28.0 → 2.32.5) and pilot-platform-common (0.3.0 → 0.8.2)
- Added AuditLog context manager and comprehensive audit logging across user authentication, role management, and invitation flows
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated Python version constraint to 3.10 and bumped package version; upgraded requests and pilot-platform-common dependencies |
| poetry.lock | Regenerated lock file with updated dependencies; removed deprecated aioredis in favor of redis; updated pilot-platform-common dependencies |
| app/logger.py | Added AuditLog context manager for structured audit logging with automatic success/failure tracking |
| app/routers/user_account_management.py | Added audit logging for user AD group operations and account enable/disable operations; moved variable declarations outside try blocks |
| app/routers/ops_user.py | Added audit logging for user authentication, token refresh, and role management operations using AuditLog context manager |
| app/routers/ops_admin.py | Added audit logging for realm role operations and user realm role retrieval |
| app/routers/invitation/invitation.py | Added audit logging for invitation creation and acceptance; replaced self._logger with logger |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.