IEBH-353: Sync with the latest changes#7
Merged
vmoshynskyi merged 2 commits intomainfrom Nov 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the codebase with the latest changes from the pilot repository, introducing significant refactoring and new features. The main changes include:
- Migration to modern Python type hints (PEP 604 style with
|for unions) - Refactoring dependency injection for Kafka, database sessions, and activity log services
- Introduction of a new version sharing feature with complete CRUD operations
- Updates to test fixtures for better isolation and consistency
- Database schema migrations for version sharing and project_id constraints
- Package version updates and infrastructure improvements
Reviewed changes
Copilot reviewed 147 out of 149 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/services/test_file_folder_activity_log_service.py | Updated to use kafka_producer_client fixture and removed pytest fixtures |
| tests/services/test_dataset_activity_log_service.py | Updated tests to use kafka_producer_client and refactored parametrized tests |
| tests/resources/test_locks.py | Added settings fixture parameter |
| tests/fixtures/services/base.py | Enhanced authorization_header to generate JWT tokens |
| tests/fixtures/s3.py | Updated MinIO Docker image to use internal registry |
| tests/fixtures/redis.py | Changed to use pytest fixture instead of pytest_asyncio |
| tests/fixtures/policy.py | Added settings parameter to minio_client fixture |
| tests/fixtures/kafka.py | Added kafka_producer_client fixture and updated scopes |
| tests/fixtures/jq.py | Changed return type from Iterable to Sequence |
| tests/fixtures/fake.py | New file introducing Faker fixture with custom methods |
| tests/fixtures/db.py | Refactored database setup with improved session management |
| tests/fixtures/components/version_sharing.py | New file for version sharing test fixtures |
| tests/fixtures/components/version.py | Updated factory pattern and added dataset_factory dependency |
| tests/fixtures/components/schema_template.py | Updated to use CRUDFactory base class |
| tests/fixtures/components/schema.py | Updated factory with fixed parameter ordering |
| tests/fixtures/components/dataset.py | Updated to use CRUDFactory base class |
| tests/fixtures/components/bids_result.py | Updated to use modern type hints |
| tests/fixtures/components/_factories.py | New file introducing CRUDFactory base class |
| tests/fixtures/components/_base_factory.py | Removed legacy base factory file |
| tests/fixtures/components/init.py | Added exports for factory classes |
| tests/fixtures/app.py | Refactored app fixtures with better settings handling |
| tests/dependencies/test_db.py | Added settings parameter to test |
| tests/conftest.py | Updated plugin list and environment setup |
| tests/components/version_sharing/*.py | New test files for version sharing feature |
| tests/components/version/test_versions.py | Updated tests with new endpoints and authorization |
| tests/components/test_*.py | Updated to use fake fixture instead of faker |
| tests/components/schema_template/test_api_schema_template.py | Fixed test data setup and assertions |
| tests/components/schema/test_api_schema.py | Added settings fixture and improved test isolation |
| tests/components/request/*.py | New test files for request network handling |
| tests/components/preview/test_api_preview.py | Added settings parameter |
| tests/components/health/test_health.py | Refactored health check tests with mocking |
| tests/components/folder/test_api_dataset_folder.py | Updated to use fake fixture |
| tests/components/file/*.py | Updated type hints and removed unused imports |
| tests/components/dataset/*.py | Updated tests with query parameter changes |
| tests/components/bids_result/test_views.py | Removed unused imports |
| pyproject.toml | Updated package versions and dependencies |
| migrations/versions/*.py | Added new migrations and formatting fixes |
| docker-compose.yaml | Updated volume paths and service configurations |
| dataset/startup/*.py | Added version_sharing router and exception logging |
| dataset/services/*.py | Updated type hints to modern style |
| dataset/dependencies/*.py | Refactored Kafka and DB dependencies with proper initialization |
| dataset/config.py | Removed vault configuration and added APP_NAME |
| dataset/components/version_sharing/*.py | New component for version sharing feature |
| dataset/components/version/*.py | Added download event tracking and new endpoints |
| dataset/components/request/*.py | New component for network origin detection |
| dataset/components//.py | Updated type hints and dependency injection patterns |
| dataset/components/activity_log/*.avsc | Updated Avro schemas with network_origin field |
| dataset/app.py | Updated tracer provider to use APP_NAME |
| README.md | Removed trailing newline |
| Dockerfile | Updated base image version |
| .pre-commit-config.yaml | Updated hook versions and pip-audit configuration |
| .github/workflows/hdc-pipeline.yml | New GitHub Actions workflow file |
| .env.example | Removed VAULT_TOKEN configuration |
Comments suppressed due to low confidence (4)
dataset/components/file/locks.py:82
- This assignment to 'minio_obj_path' is unnecessary as it is redefined before this value is used.
This assignment to 'minio_obj_path' is unnecessary as it is redefined before this value is used.
This assignment to 'minio_obj_path' is unnecessary as it is redefined before this value is used.
bucket, minio_obj_path = None, None
dataset/components/file/locks.py:147
- This assignment to 'minio_obj_path' is unnecessary as it is redefined before this value is used.
This assignment to 'minio_obj_path' is unnecessary as it is redefined before this value is used.
bucket, minio_obj_path = None, None
dataset/components/file/locks.py:207
- This assignment to 'minio_obj_path' is unnecessary as it is redefined before this value is used.
This assignment to 'minio_obj_path' is unnecessary as it is redefined before this value is used.
This assignment to 'minio_obj_path' is unnecessary as it is redefined before this value is used.
bucket, minio_obj_path = None, None
dataset/components/file/locks.py:278
- This assignment to 'minio_obj_path' is unnecessary as it is redefined before this value is used.
This assignment to 'minio_obj_path' is unnecessary as it is redefined before this value is used.
bucket, minio_obj_path = None, None
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the latest changes from the pilot repo.