Skip to content

IEBH-353: Sync with the latest changes#10

Merged
vmoshynskyi merged 1 commit intomainfrom
IEBH-353
Nov 24, 2025
Merged

IEBH-353: Sync with the latest changes#10
vmoshynskyi merged 1 commit intomainfrom
IEBH-353

Conversation

@vmoshynskyi
Copy link
Member

Add the latest changes from the pilot repo.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR synchronizes the notification service repository with the latest changes from the pilot repository. It includes fixture improvements, configuration cleanup, dependency updates, CI/CD migration from Jenkins to GitHub Actions, and code formatting standardization.

Key changes:

  • Replaced yield with return in fixtures that don't require cleanup/teardown
  • Removed Vault-based configuration in favor of direct environment variable management
  • Updated Python version constraint and base Docker image
  • Migrated from Jenkins to GitHub Actions for CI/CD

Reviewed changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/fixtures/jq.py Changed fixture from yield to return and added pass statements to stub methods
tests/fixtures/app.py Changed project_root fixture from yield to return and improved path detection logic
pyproject.toml Updated version to 2.2.10 and changed Python requirement from ^3.10 to >=3.10,<3.11
notification/config.py Removed VaultConfig class and vault-related configuration logic
notification/components/email/templates/role/update.html Normalized whitespace formatting
notification/components/email/templates/resource_request/vm_password_reset.html Added missing newline at end of file
migrations/versions/*.py Removed blank lines between license header and docstring (9 files)
Jenkinsfile Deleted Jenkins pipeline configuration file
Dockerfile Updated base image from python-3.10.12-v2 to python-3.10.14-v1
.pre-commit-config.yaml Uncommented and updated docformatter hook from v1.7.5 to v1.7.7
.github/workflows/hdc-pipeline.yml Added new GitHub Actions workflow for CI/CD
.env.example Removed Vault-related environment variables

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
__main__.py050%7, 9, 11–13
app.py0886%104, 110, 119–120, 122, 126, 128–129
config.py0295%55–56
logger.py00100% 
components
   __init__.py00100% 
   crud.py0396%69–70, 99
   db_model.py00100% 
   exceptions.py01373%22, 29, 36, 41, 52, 56, 60, 68, 72, 76, 84, 88, 92
   filtering.py0191%30
   models.py00100% 
   pagination.py00100% 
   parameters.py0196%63
   schemas.py0197%34
   sorting.py00100% 
   types.py00100% 
components/announcement
   __init__.py00100% 
   crud.py00100% 
   dependencies.py00100% 
   filtering.py00100% 
   models.py00100% 
   parameters.py00100% 
   schemas.py00100% 
   views.py00100% 
components/email
   __init__.py00100% 
   dependencies.py00100% 
   email_client.py01273%38–43, 61–66
   schemas.py0595%52, 55, 139–140, 142
   views.py00100% 
components/health
   __init__.py00100% 
   db_checker.py00100% 
   dependencies.py00100% 
   views.py00100% 
components/notification
   __init__.py00100% 
   crud.py00100% 
   dependencies.py00100% 
   filtering.py00100% 
   models.py00100% 
   parameters.py0294%30, 71
   schemas.py00100% 
   views.py00100% 
dependencies
   __init__.py00100% 
   db.py00100% 
TOTAL12675395% 

@vmoshynskyi vmoshynskyi merged commit 338f792 into main Nov 24, 2025
13 checks passed
@vmoshynskyi vmoshynskyi deleted the IEBH-353 branch November 24, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant