IEBH-353: Sync with the latest changes#10
Merged
vmoshynskyi merged 1 commit intomainfrom Nov 24, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the notification service repository with the latest changes from the pilot repository. It includes fixture improvements, configuration cleanup, dependency updates, CI/CD migration from Jenkins to GitHub Actions, and code formatting standardization.
Key changes:
- Replaced
yieldwithreturnin fixtures that don't require cleanup/teardown - Removed Vault-based configuration in favor of direct environment variable management
- Updated Python version constraint and base Docker image
- Migrated from Jenkins to GitHub Actions for CI/CD
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/fixtures/jq.py | Changed fixture from yield to return and added pass statements to stub methods |
| tests/fixtures/app.py | Changed project_root fixture from yield to return and improved path detection logic |
| pyproject.toml | Updated version to 2.2.10 and changed Python requirement from ^3.10 to >=3.10,<3.11 |
| notification/config.py | Removed VaultConfig class and vault-related configuration logic |
| notification/components/email/templates/role/update.html | Normalized whitespace formatting |
| notification/components/email/templates/resource_request/vm_password_reset.html | Added missing newline at end of file |
| migrations/versions/*.py | Removed blank lines between license header and docstring (9 files) |
| Jenkinsfile | Deleted Jenkins pipeline configuration file |
| Dockerfile | Updated base image from python-3.10.12-v2 to python-3.10.14-v1 |
| .pre-commit-config.yaml | Uncommented and updated docformatter hook from v1.7.5 to v1.7.7 |
| .github/workflows/hdc-pipeline.yml | Added new GitHub Actions workflow for CI/CD |
| .env.example | Removed Vault-related environment variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the latest changes from the pilot repo.