Skip to content

IEBH-464: Add timeout for service clients#11

Merged
vmoshynskyi merged 1 commit intomainfrom
IEBH-464
Jan 21, 2026
Merged

IEBH-464: Add timeout for service clients#11
vmoshynskyi merged 1 commit intomainfrom
IEBH-464

Conversation

@vmoshynskyi
Copy link
Member

  • Default 5 second timeout causes httpx.ReadTimeout exceptions in some slow environments.
  • Removed obsolete Jenkinsfile.
  • Updated common package.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses timeout issues in service client HTTP calls by adding explicit timeout configuration to prevent httpx.ReadTimeout exceptions in slow environments.

Changes:

  • Added timeout parameter to service client constructors (MetadataClient, AuthClient, PolicyManager) and their httpx.AsyncClient instances
  • Updated pilot-platform-common package from 0.3.0 to 0.8.2, which includes dependency changes (redis replacing aioredis)
  • Removed obsolete Jenkinsfile

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
project/services/metadata.py Added timeout parameter to MetadataClient constructor and AsyncClient instance
project/services/auth.py Added timeout parameter to all AsyncClient instances in AuthClient methods
project/components/object_storage/policy.py Added timeout parameter to PolicyManager constructor and AsyncClient instance
tests/services/test_metadata.py Updated test fixture to pass timeout parameter
pyproject.toml Bumped version to 2.3.9 and updated pilot-platform-common to 0.8.2
poetry.lock Updated dependencies reflecting the common package upgrade
Jenkinsfile Removed obsolete CI/CD configuration file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
__main__.py050%7, 9, 11–13
app.py0690%111, 124–125, 127, 129, 133
config.py00100% 
logger.py00100% 
components
   __init__.py00100% 
   crud.py0694%90, 117, 125, 149–150, 152
   db_model.py00100% 
   exceptions.py0692%29, 36, 43, 107, 111, 115
   filtering.py0191%30
   models.py00100% 
   pagination.py00100% 
   parameters.py0196%63
   schemas.py0196%30
   sorting.py00100% 
   types.py00100% 
components/health
   __init__.py00100% 
   db_checker.py00100% 
   dependencies.py00100% 
   views.py00100% 
components/object_storage
   __init__.py00100% 
   policy.py0689%79–81, 83–85
   policy_templates.py00100% 
   s3.py0197%49
components/project
   __init__.py00100% 
   crud.py00100% 
   dependencies.py00100% 
   filtering.py00100% 
   logo_uploader.py0981%34–36, 55–57, 64–66
   models.py00100% 
   object_storage_manager.py0391%27, 30–31
   parameters.py0197%46
   schemas.py0394%77–78, 82
   views.py00100% 
components/resource_request
   __init__.py00100% 
   crud.py00100% 
   dependencies.py00100% 
   filtering.py00100% 
   models.py00100% 
   parameters.py00100% 
   schemas.py00100% 
   sorting.py00100% 
   views.py00100% 
components/workbench
   __init__.py00100% 
   crud.py00100% 
   dependencies.py00100% 
   filtering.py00100% 
   models.py00100% 
   parameters.py00100% 
   schemas.py00100% 
   views.py00100% 
dependencies
   __init__.py00100% 
   db.py0575%36, 38–40, 42
   s3.py00100% 
services
   __init__.py00100% 
   auth.py01284%46–48, 69–71, 90–92, 117–119
   metadata.py0491%34, 83–85
TOTAL13827094% 

@vmoshynskyi vmoshynskyi changed the title IEBH-464: Add missing timeout service clients IEBH-464: Add timeout for service clients Jan 21, 2026
@vmoshynskyi vmoshynskyi merged commit 6898903 into main Jan 21, 2026
13 checks passed
@vmoshynskyi vmoshynskyi deleted the IEBH-464 branch January 21, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant