-
Notifications
You must be signed in to change notification settings - Fork 0
Project Milestone 3 complete. Pushing changes #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 build auth views
Modified checkstyle for Package Names to accommodate our naming conventions. Renamed other packages to abide by this convention.
Fixed trivial checkstyle errors.
I also added various classes to support this View (non-exhaustive).
…ad buttons and incorportate clean architecture for the interface adapters
…luding a view button), and added TODO's for Robert -fixed checkstyle mostly
Added a barebones view for the "send message" user case.
Updated Javadocs for some classes associated with the Send Message use case. Deleted LoggedInView, as we will be replacing it with ThreadsView.
Fixed a few more Checkstyle things.
Changes list type from array to array list in ThreadPane (this can be changed back later, just ot make it compile)
Made it so that ThreadsView compiles.
Threads view
Added all the necessary Application-level files for the send-message use case.
Implemented the "Return To Threads Button." Had to change the name of the view name in ThreadsViewModel from "ThreadsViewState" to "threads"
Send message setup
Updated Javadocs for some classes associated with the Send Message use case. Deleted LoggedInView, as we will be replacing it with ThreadsView.
Added all the necessary Application-level files for the send-message use case.
Implemented the "Return To Threads Button." Had to change the name of the view name in ThreadsViewModel from "ThreadsViewState" to "threads"
- Implemented multiple test cases to validate GetThreadsInteractor functionality, including success and error scenarios. - Added mock DAOs (InMemoryThreadDataAccess and InMemoryThreadDataAccessWithError) to simulate server behaviors. - Fully implemented all methods required by GetThreadsThreadDataAccessInterface in the mock DAOs. - Enhanced test coverage for switching views (chat and add thread view). - Ensured all interface methods are properly handled to prevent compile-time issues.
…nto minorChangeGetThreads
GetThreads Interactor Test + minor fixes
Modificarions to ChatView(can now scorll to bottom)
Revert "Modificarions to ChatView(can now scorll to bottom)"
Changed Button in Login View
… method implementations. Added 2 new test cases for better coverage.
Improved Code Coverage Test Class
Added Homepage
Fixed last test
Fix scroll bottom message display
Signup fixes
MatteoGentili24
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.