Threadsview bug fixes #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Benjamin-Gavriely
commented
Dec 2, 2024
Benjamin-Gavriely
commented
- Fixed threadsview to put all new threads on the top of the panel instead of stretching it out.
- Fixed bug where threads buttonlabels remained from the previous sign in on the screen when signing up as a new user.
- Fixed some checkstyle.
…ead of stretching it out. Fixed bug where threads buttonlabels remained from the previous sign in on the screen when signing up as a new user.
bennypk1
approved these changes
Dec 2, 2024
Contributor
bennypk1
left a comment
bennypk1
left a comment
There was a problem hiding this comment.
The recent changes introduce significant improvements to the LogoutPresenter, ThreadsPane, and associated UI classes by refining their functionalities and ensuring better user interaction flow. The incorporation of a reset method in ThreadsState and ThreadsPane provides a cleaner and more modular way to clear or update data, adhering to good separation of concerns principles. However, there is some duplication in the method definitions and implementations that could be consolidated to enhance maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.