Skip to content

Conversation

@bennypk1
Copy link
Contributor

@bennypk1 bennypk1 commented Dec 2, 2024

  • fixed bug Ali pointed out in send message presenter
  • Removed unnecessary User DAI for AddThread use case
  • many checkstyle fixes, especially in data access

Copy link
Contributor

@Roppax Roppax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR brings important changes, particularly in exception handling and API interactions. The enhancements in PingBackend and DAOs, like descriptive exception messages and refined JSON parsing, make the backend interactions more reliable. The addition of getThreadsByUsername in ThreadDataAccessObject is a good improvement, aligning well with use case requirements.

The changes in ChatView and ThreadsView show property change handling, which simplifies how updates are managed. Removing unnecessary code, such as unnecessary imports and unused interfaces, improves readability and maintainability across the project.

Overall, these updates improve the codebase's clarity. I believe that adding tests for the new DAO methods would be a helpful next step to make sure the changes hold up. Nice work!

@Roppax Roppax merged commit 85c9f2f into dev Dec 2, 2024
1 check failed
@bennypk1 bennypk1 deleted the Small-Benedict-Fixes branch December 3, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants