GetThreads Interactor Test + minor fixes #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and to debulk the code. Had to get rid of them from the Interface and in the DAO which implements them.
…e and to debulk the code. Had to get rid of them from the Interface and in the DAO which implements them.
- Implemented multiple test cases to validate GetThreadsInteractor functionality, including success and error scenarios. - Added mock DAOs (InMemoryThreadDataAccess and InMemoryThreadDataAccessWithError) to simulate server behaviors. - Fully implemented all methods required by GetThreadsThreadDataAccessInterface in the mock DAOs. - Enhanced test coverage for switching views (chat and add thread view). - Ensured all interface methods are properly handled to prevent compile-time issues.
…nto minorChangeGetThreads
crypto-a
approved these changes
Dec 2, 2024
bennypk1
approved these changes
Dec 2, 2024
Contributor
bennypk1
left a comment
bennypk1
left a comment
There was a problem hiding this comment.
Test classes look good, it is not yet at 100% coverage, but we talked about that and I'm expecting a follow up pull request for this. Additionally, great job removing the UserDAI for your use case, as determined that it was not needed, and was cluttering the project. It's great that your use case now only makes one API call and there are less variables at play.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created test class for GetThreads Interactor along with some minor fixes deleting 2 methods from the Threads Interface and their respective implementations in the GetThreadsDAO