Skip to content

Move roots to interpax and add refine points method#2042

Merged
unalmis merged 4 commits intoku/bouncefrom
ku/points
Dec 18, 2025
Merged

Move roots to interpax and add refine points method#2042
unalmis merged 4 commits intoku/bouncefrom
ku/points

Conversation

@unalmis
Copy link
Collaborator

@unalmis unalmis commented Dec 16, 2025

Resolves #1388 .

  • uses obvious method for fft grids
  • removes redundant computation in polyroot_vec by factor of num pitch
  • adds refine points method
  • remove method and tests after Add polyroot f0uriest/interpax#146 is merged. bump min required interpax. Then call from interpax._spline import _polyroot_vec. Will need to wrap it with functools partial and eps=same default arg but in jax x64 precision since interpax default is x32.)

@unalmis unalmis linked an issue Dec 16, 2025 that may be closed by this pull request
2 tasks
@unalmis unalmis added the easy Short and simple to code or review label Dec 16, 2025
@unalmis unalmis requested a review from f0uriest December 16, 2025 07:37
@unalmis unalmis added the run_benchmarks Run timing benchmarks on this PR against current master branch label Dec 16, 2025
@unalmis unalmis self-assigned this Dec 16, 2025
Added information about memory consumption and parameter settings in rev mode.
@unalmis unalmis removed the run_benchmarks Run timing benchmarks on this PR against current master branch label Dec 17, 2025
@unalmis unalmis changed the title Move roots to interpax Move roots to interpax and add refine points method Dec 18, 2025
@unalmis unalmis merged commit cebddfb into ku/bounce Dec 18, 2025
4 of 5 checks passed
@unalmis unalmis deleted the ku/points branch December 18, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy Short and simple to code or review waiting for other PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move some general interpolation functions into interpax

1 participant