Save base response when radio button with other is used#613
Open
Jenczu11 wants to merge 2 commits intoPoetOS:MOODLE_404_STABLEfrom
Open
Save base response when radio button with other is used#613Jenczu11 wants to merge 2 commits intoPoetOS:MOODLE_404_STABLEfrom
Jenczu11 wants to merge 2 commits intoPoetOS:MOODLE_404_STABLEfrom
Conversation
mchurchward
reviewed
Feb 20, 2025
| if ($onlyspaces) { | ||
| $answered = false; | ||
| } | ||
| } else { |
Contributor
There was a problem hiding this comment.
The above code could be simplified to:
$answered = !empty($answer->value) || !preg_match("/^[\s]*$/", $answer->value);
Contributor
There was a problem hiding this comment.
Is there a case for answering "other" with no content?
mchurchward
reviewed
Feb 20, 2025
| $record->choice_id = $answer->choiceid; | ||
| $record->response = clean_text($answer->value); | ||
| $DB->insert_record('questionnaire_response_other', $record); | ||
| } |
Contributor
There was a problem hiding this comment.
I'm not 100% sure this is what is desired. If the user didn't select a response, why would a response be saved? Please provide a test case
mchurchward
reviewed
Feb 20, 2025
Contributor
mchurchward
left a comment
mchurchward
left a comment
There was a problem hiding this comment.
Left comments inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes should fix 2 things.
Without this you when you are submitting
otherresponse containing only spaces no error occurs.There should be some kind of validation / error when
otherresponse contains only spaces.When submitting question with
otherresponse there was acontinue(which applies to foreach / loop) if$answer->valuewas empty or contained only spaces.It was skipping saving of original base choice.
So on report page there was no info what user selected / answered.
This commit inverts the logic so base save is always happening.