Skip to content

Fixed sizeof() call in P1_PrintData(). #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamshapiro0 merged 3 commits into from
Nov 3, 2025
Merged

Fixed sizeof() call in P1_PrintData(). #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c77203a
Fixed sizeof() call in P1_PrintData().
adamshapiro0 Oct 30, 2025
b9923f8
Specify both CXX and CC for CI cmake builds.
adamshapiro0 Oct 31, 2025
91e114a
Build C/C++ libraries with clang in CI.
adamshapiro0 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/release_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ jobs:
os: ubuntu-latest
tool: bazel-6.5.0
compiler: g++
- arch: x64
os: ubuntu-latest
tool: cmake
compiler: clang++
# Windows not currently supported by C++ library.
#- arch: x64
# os: windows-latest
Expand All @@ -51,6 +55,11 @@ jobs:
if: matrix.os == 'ubuntu-latest'
run: |
echo "CXX=/usr/bin/${{ matrix.compiler }}" >> $GITHUB_ENV
if [[ "${{ matrix.compiler }}" == "clang++" ]]; then
echo "CC=/usr/bin/clang" >> $GITHUB_ENV
else
echo "CC=/usr/bin/gcc" >> $GITHUB_ENV
fi
echo "EXT=" >> $GITHUB_ENV
# Just for Github action builds set USE_BAZEL_VERSION to override the
# bazelversion file so we can test different Bazel versions even though
Expand Down Expand Up @@ -201,12 +210,16 @@ jobs:
os: [ubuntu-latest]
tool: [make, cmake, bazel-4.2.2, bazel-6.5.0]
compiler: [g++]
#include:
# Windows not currently supported by C library.
# - arch: x64
# os: windows-latest
# tool: cmake
# compiler: msvc
include:
- arch: x64
os: ubuntu-latest
tool: cmake
compiler: clang++
# Windows not currently supported by C library.
#- arch: x64
# os: windows-latest
# tool: cmake
# compiler: msvc
defaults:
run:
shell: bash
Expand All @@ -224,6 +237,11 @@ jobs:
if: matrix.os == 'ubuntu-latest'
run: |
echo "CXX=/usr/bin/${{ matrix.compiler }}" >> $GITHUB_ENV
if [[ "${{ matrix.compiler }}" == "clang++" ]]; then
echo "CC=/usr/bin/clang" >> $GITHUB_ENV
else
echo "CC=/usr/bin/gcc" >> $GITHUB_ENV
fi
echo "EXT=" >> $GITHUB_ENV
# Just for Github action builds set USE_BAZEL_VERSION to override the
# bazelversion file so we can test different Bazel versions even though
Expand Down
2 changes: 1 addition & 1 deletion c/src/point_one/polaris/polaris.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1385,7 +1385,7 @@ void P1_PrintData(const uint8_t* buffer, size_t length) {
}

str_length +=
snprintf(str + str_length, sizeof(str - str_length), "%02x", buffer[i]);
snprintf(str + str_length, sizeof(str) - str_length, "%02x", buffer[i]);

if (i % 16 == 15) {
str[str_length++] = '\0';
Expand Down