Draft
Conversation
anth-volk
requested changes
Jul 24, 2025
Collaborator
anth-volk
left a comment
anth-volk
left a comment
There was a problem hiding this comment.
I left a couple comments here, but @v-lerie I think we should perhaps discuss what's going on here. I don't fully understand the underlying bug from this code, so would love to talk about implementation, as I think these changes move away from some behavior that we do desire.
| @@ -1,3 +1,11 @@ | |||
| from google.cloud.logging import Client | |||
| import os | |||
Collaborator
There was a problem hiding this comment.
issue, blocking: I believe this code is bleed-over from another PR.
Please remove so that we can keep those changes isolated to their own PR.
|
|
||
| if row is None: | ||
| raise NotFound("No such user") | ||
| _, row = user_service.create_profile( |
Collaborator
There was a problem hiding this comment.
issue, blocking: I don't think this is the behavior we want here
Ideally, we should raise a NotFound when a user doesn't exist, thereby returning a 404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2340