Convert from npm to bun #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MaxGhenis
requested review from
SakshiKekre and
anth-volk
and removed request for
anth-volk
anth-volk
requested changes
Jan 30, 2026
Collaborator
anth-volk
left a comment
anth-volk
left a comment
There was a problem hiding this comment.
I'm able to install this code, but when attempting to run make dev, I get an endless loop of bun attempting to build the design package file, and the number of times the package invokes the policyengine-app-v2 filter increases each time the loop attempts to build. I'm going to guess there's a circular dependency somewhere in this setup.
Contributor
Author
|
Fixed the infinite loop issue. The problem was the Root cause: In bun,
The output showed the bug clearly — each iteration accumulated another After the fix, |
anth-volk
approved these changes
Feb 5, 2026
Collaborator
anth-volk
left a comment
anth-volk
left a comment
There was a problem hiding this comment.
Thank you, this does now work. Could you just deal with the merge conflicts? Then this should be good to go.
React Query now passes additional context parameters (client, meta, mutationKey) to mutation functions. Updated test assertions to check only the first argument (the actual payload) instead of exact parameter matching. Changes: - Check mock was called, then verify first argument with .mock.calls[0][0] - This allows tests to pass regardless of additional React Query context Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change installCommand to use bun install --frozen-lockfile - Change buildCommand to use bun run commands - Applies to root vercel.json (website) and calculator/vercel.json Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update app/package.json scripts to use 'bun run' instead of previous package manager - Simplify Vercel build commands to cd into app directory and run build scripts directly - Remove workspace flags that don't work with Bun - Ensure design-system builds before calculator and website Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The --filter flag must come before the script name in bun run commands. When placed after (e.g., `bun run dev --filter=pkg`), it's passed as an argument to the script rather than being interpreted as a workspace filter, causing infinite recursion. Fixes the issue where `make dev` would loop endlessly, accumulating --filter arguments with each iteration. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
anth-volk
force-pushed
the
convert-to-bun
branch
from
fbe8ac9 to
dd4be7d
Compare
Collaborator
|
Took the liberty of fixing new merge conflicts I created by merging #636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
oven-sh/setup-bun@v2andbun install --frozen-lockfileTest plan
make install && make devmake buildGenerated with Claude Code
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com