You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR Fixes#2104 by adding a queued label and queue position display to the Simulations page, addressing issue #2104. The motivation is to provide users with clear feedback on their simulation's status in the processing queue, rather than showing all queued jobs as "computing." This improves transparency and user experience by indicating both the queue position and when a simulation is actively calculating.
Changes
Updated the Simulations page to display:
An orange "POSITION IN QUEUE: X" label for simulations with queue_position > 0
A blue "CALCULATING" label for simulations with queue_position === 0 or missing
The "Queue Position" column now always shows the queue position value or a dash if not present
Ensured the frontend expects and handles the queue_position field from the backend /simulations API
Added test data to the frontend to visually verify all queue/calculate display cases
Tests
Manually verified the following cases in the UI:
Simulations with queue_position > 0 display "POSITION IN QUEUE: X" (orange tag) in the status column and the correct number in the Queue Position column.
Simulations with queue_position === 0 display "CALCULATING" (blue tag) in the status column and 0 in the Queue Position column.
Simulations with no queue_position display "CALCULATING" (blue tag) in the status column and a dash ("—") in the Queue Position column.
Completed and errored simulations display the correct status and a dash in the Queue Position column.
Screenshots
Note: I am not aware of what data values to enter into the simulation, so I test all possibilities in the UI, not hardcoded, so if you can guide me through this to make sure it is working properly.
Hi @nadamakram, my apologies for the delay. I'll be working through some PR backlog over the next couple days and will address then. Thanks for your patience.
@nadamakram could you run make format as described in our README? Also, if you check out my update to the original issue, I'm not 100% sure how to proceed with this, as we don't have the same queue logic that we used to now that we're using a new API for computations.
@nadamakram could you run make format as described in our README? Also, if you check out my update to the original issue, I'm not 100% sure how to proceed with this, as we don't have the same queue logic that we used to now that we're using a new API for computations.
I am not sure also
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR Fixes #2104 by adding a queued label and queue position display to the Simulations page, addressing issue #2104. The motivation is to provide users with clear feedback on their simulation's status in the processing queue, rather than showing all queued jobs as "computing." This improves transparency and user experience by indicating both the queue position and when a simulation is actively calculating.
Changes
Updated the Simulations page to display:
Tests
Manually verified the following cases in the UI:
Simulations with queue_position > 0 display "POSITION IN QUEUE: X" (orange tag) in the status column and the correct number in the Queue Position column.
Simulations with queue_position === 0 display "CALCULATING" (blue tag) in the status column and 0 in the Queue Position column.
Simulations with no queue_position display "CALCULATING" (blue tag) in the status column and a dash ("—") in the Queue Position column.
Completed and errored simulations display the correct status and a dash in the Queue Position column.
Screenshots
Note: I am not aware of what data values to enter into the simulation, so I test all possibilities in the UI, not hardcoded, so if you can guide me through this to make sure it is working properly.