Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #528
Overview
This PR implements missing provincial tax credit and benefit programs identified in issue #528 as part of
the SPSD/M parity effort. The implementation adds 3 new provincial programs with comprehensive test
coverage.
Summary:
Detailed Implementation
Purpose: Offsets sales tax impact for low-income BC residents
Implementation:
Purpose: Provides financial assistance to low-income Alberta seniors
Implementation:
Purpose: Helps offset housing costs and QST for low/middle-income Quebec households
Implementation:
Files Changed
Variables: 10 new files
Parameters: 19 new files
Tests: 3 new files
Total: 32 new files
Programs Not Implemented
Manitoba Education Property Tax Credit
Reason: Requires is_homeowner variable that doesn't exist in the current system. Implementation would
require:
This should be addressed in a separate PR focused on property-related variables.
Nova Scotia Affordable Living Tax Credit
Reason: Already implemented in the codebase at:
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/nsaltc/ns_affordable_living_tax_credit.py
References