Adding support for blank value on resize/fitin and improving filter input#3
Open
maclovin wants to merge 2 commits intoPolicyMic:masterfrom
Open
Adding support for blank value on resize/fitin and improving filter input#3maclovin wants to merge 2 commits intoPolicyMic:masterfrom
maclovin wants to merge 2 commits intoPolicyMic:masterfrom
Conversation
…nput -On Thumbor Server you can set blank values to "Resize" and "Fitin" (100x or x100). So I decided to implement this option on your lib. -When you need to use the same Thumbor instance (Secret + Server) to create other urls, it makes copies of the same filter in the Url (/fill(white):fill(white):fill(white)). I decided to create a check on the filtersCalls push. In this way, we don't need to create another Thumbor instance to use the same filters with another image url.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-On Thumbor Server you can set blank values to "Resize" and "Fitin" (100x or x100). So I decided to implement this option on your lib.
-When you need to use the same Thumbor instance (Secret + Server) to create other urls, it makes copies of the same filter in the Url (/fill(white):fill(white):fill(white)).
I decided to create a check on the filtersCalls push. In this way, we don't need to create another Thumbor instance to use the same filters with another image url.
-Removing console.log.