Skip to content

Conversation

@Huygon764
Copy link
Contributor

@Huygon764 Huygon764 commented Dec 24, 2025

All tested flow:

  • Create wallet (2 signers, threshold=2)
  • Set threshold (2 -> 1)
  • Add signer (signers=3)
  • Remove signer (signers=2)
  • Transfer ETH
  • Batch ETH
  • Transfer USDC
  • Batch ETH + USDC

Advanced flow

  1. Removed existed vote in tx:
  • Create tx1 (remove signer A) (1/1)
  • Create tx2 with approve from signerA (transfer) (1/1)
  • Execute tx 1 (remove signer A)
  • Approval signerA from tx2 is removed (0/1)
  1. Increase threshold with pending Tx
  • User A create tx1, A approve (1/1)
  • Set threshold (1 -> 2) -> Execute
  • Tx 1 need 2 approval
  • User B approve -> Execute
  1. Execute after add signer:
  • User A create tx1, A approve (1/2)
  • Add signer C -> Execute
  • User B approve tx1 (2/2)
  • Tx1 execute successful
  1. Decrease threshold with pending Tx
  • User A create tx1, A approve (1/2)
  • Set threshold (2 -> 1) -> Execute
  • Tx 1 just need 1 approval -> execute

@gianalarcon gianalarcon merged commit cfe7a24 into main Dec 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants