Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Conversation

@hcarmona
Copy link

@hcarmona hcarmona commented Mar 3, 2018

Fixes 130 by making the selector more specific

@notwaldorf
Copy link
Contributor

notwaldorf commented Mar 5, 2018

I don't think this works; you can't target children of the distributed element (so nothing after the slotted( ). I've tried this patch locally, and I don't see the styles being applied.

While I'm trying to find a better fix, I think for now you have to style the paper-ripple at the point where you're distributing the button, so something like:

<custom-style>
  <style>
        paper-ripple {
          opacity: 0.6;
          color: red;
       }
  </style>
</custom-style>

<paper-icon-button-light>
  <button title="heart">
    <iron-icon icon="favorite"></iron-icon>
  </button>
</paper-icon-button-light>

/cc @kevinpschaaf

@notwaldorf
Copy link
Contributor

notwaldorf commented Mar 7, 2018

I think there are only 2 choices available:

  • if all you need to style is the opacity and color, we can inline style (on the paper-ripple) something like this, and you'd style the wrapping paper-icon-container-light (and give it the default of opacity 0.6 in the :host
opacity: inherit;
color: inherit;
  • always require you (the user) to style the paper-ripple from the point you're distributing the button.

I'm leaning towards doing the default inherit, since that's probably what you need in 90% of cases.

WDYT?

Copy link
Contributor

@notwaldorf notwaldorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see comments above)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants