This repository was archived by the owner on Dec 19, 2024. It is now read-only.
stop propagation of iron-overlay-opened/closed/canceled #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valdrinkoshi
force-pushed
the
stop-iron-dropdown-events-propagation
branch
2 times, most recently
from
21029b6 to
0dd9655
Compare
Contributor
|
I am mildly, very mildly, concerned this may be a breaking change. If it's easier to make this decision, we can punt it to the 2.0 release |
Member
Author
|
SG, will tag as a breaking change for now |
Contributor
|
@valdrinkoshi Can we open an issue, tag it with 2.0, maybe reference this PR and then close this PR? In it's current state it won't be merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86 by stopping these events' propagation to the element itself. Added tests to check if the parent receives this event.