Added pinLabel property. #167
Conversation
paper-slider.html
Outdated
| */ | ||
| pinLabel: { | ||
| type: String, | ||
| value: "", |
There was a problem hiding this comment.
Default value and notify property are unnecessary.
|
Well it does offer a solution to that issue. I implemented this because I had a problem where I needed to format the numbers into a timestamp instead of showing just a number, since I use this slider as a slider to seek in a video. This offers a way to support both. |
| * If set, a this text will be used in the pin instead of just the numeric | ||
| * number. Use if you need to format the label in any way. | ||
| */ | ||
| pinLabel: { |
There was a problem hiding this comment.
My mistake - you do need a default value of '' for pinLabel because the value$="[[_getPinLabel(pinLabel, immediateValue)]]" computed binding won't be evaluated unless both arguments are defined.
| { | ||
| "name": "paper-slider", | ||
| "version": "1.0.12", | ||
| "version": "1.0.13", |
There was a problem hiding this comment.
Please don't update bower.json/version number with this PR - we will do that separately and publish a release separately.
|
Since this is a new feature, tt'd be great to add a demo and a test. |
3 participants
Solves #133 although with a little more customization than suggested there.
I've added an optional pinLabel property that if set, will be used for the pin label instead of just the immediateValue. That way, you can create your own text with bindings, like so:
immediate-value="{{durationSliderValue}}" pin-label="[[_readableDuration(durationSliderValue)]]"If not set, the value will be used as normal, so no breaking changes.