Open
Conversation
- Added flag to turn on debug mode. - made CLI more conventional - documented tool - added a few more log stmts
bgogul
requested changes
Apr 30, 2021
Collaborator
bgogul
left a comment
bgogul
left a comment
There was a problem hiding this comment.
The additional log statements can result in too much debug information. Can we remove them?
|
|
||
| /** Returns true if the [check] is satisfied by the labels computed for [particle]. */ | ||
| fun InformationFlow.AnalysisResult.verify(particle: Recipe.Particle, check: Check): Boolean { | ||
| val log = TaggedLog { "AnalysisResult.verify" } |
Collaborator
There was a problem hiding this comment.
This is too much debug information. Let us not keep these log.debug statements.
Contributor
Author
There was a problem hiding this comment.
Sure thing, just pushed a reversion.
| .flag(default = false) | ||
|
|
||
| override fun run() { | ||
| if (debug) { |
bgogul
approved these changes
May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC: @cromwellian, @jasonwyatt, @csilvestrini