-
Notifications
You must be signed in to change notification settings - Fork 377
Fix test criteria to fix paqa_latency.c #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
qa/paqa_latency.c
Outdated
| { | ||
| QA_ASSERT_TRUE( " final latency should increase with suggested latency", (finalLatency > previousLatency) ); | ||
| QA_ASSERT_TRUE( "Latency should increase monotonically with the suggested latency.", | ||
| finalLatency > (previousLatency - 0.001)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I regard any decreasing behavior, even due to rounding error, as a bug, therefore I suggest:
| finalLatency > (previousLatency - 0.001)); | |
| finalLatency >= previousLatency); |
|
After discussion with Ross, the plan is to:
|
Just expect monotonic increases, and not much higher latency than suggested. Fixes #742
deb402c to
fbecb61
Compare
I added that test. But we are seeing failures where the latency hits the maximum and then keeps going up! also |
It was failing because the latency was too low.
Now we allow lower latency.
Fixes #742