feat: propagate personProperties and groups in feature flag events #383
+126
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `getFeatureFlagStateless` calls `captureStateless` for the `$feature_flag_called` event, it now propagates the `personProperties` (as userProperties) and `groups` to the event. Previously these properties were available but not passed through, meaning the feature flag evaluation context was lost in the captured event. This ensures that when analyzing feature flag events in PostHog, the user properties and group context are properly attached for accurate targeting and analysis. Fixes part of the issue by ensuring proper event context propagation.
marandaneto
reviewed
Jan 22, 2026
Comment on lines
+457
to
+459
| val userProps = personProperties | ||
| ?.filterValues { it != null } | ||
| ?.mapValues { it.value!! } |
Member
There was a problem hiding this comment.
why do we do this instead of just passing personProperties?
Member
|
@dustinbyrne i think you'd know better what exactly the problem here is |
dustinbyrne
reviewed
Jan 22, 2026
| PostHogEventName.FEATURE_FLAG_CALLED.event, | ||
| distinctId, | ||
| properties = props, | ||
| userProperties = userProps, |
Contributor
There was a problem hiding this comment.
Providing userProperties here will mutate persisted person properties. That seems unexpected for a feature flag called event.
What's the behavior we're looking for by doing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
personProperties(asuserProperties) andgroupstocaptureStatelesswhen$feature_flag_calledevents are sent during feature flag evaluationSplit from original PR addressing contributor feedback to keep changes focused.