feat: add evaluationContexts support to server PostHogConfig #385
+70
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server module's PostHogConfig was missing the evaluationContexts property that exists in the core PostHogConfig. This meant that even when users set evaluationContexts in their server config, it wasn't being propagated to the core config and therefore wasn't sent in /flags API requests. This change: - Adds evaluationContexts property to server PostHogConfig constructor - Propagates evaluationContexts to core config in asCoreConfig() - Adds evaluationContexts() method to the Builder class
dustinbyrne
dismissed
their stale review
Missed this initially - but can you add a CHANGELOG entry for this?
Contributor
Author
|
done @dustinbyrne |
dustinbyrne
approved these changes
Jan 23, 2026
Contributor
dustinbyrne
left a comment
dustinbyrne
left a comment
There was a problem hiding this comment.
Thanks again @igormq!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
evaluationContextsproperty that exists in the core PostHogConfigevaluationContextsin their server config, it wasn't being propagated to the core config and therefore wasn't sent in/flagsAPI requestsevaluationContextsproperty to server PostHogConfig constructorevaluationContextsto core config inasCoreConfig()evaluationContexts()method to the Builder classSplit from original PR addressing contributor feedback to keep changes focused.