fix(metrics): prevent pgrst_db_pool_available drifting below zero#4630
Open
nothankyouzzz wants to merge 2 commits intoPostgREST:mainfrom
Open
fix(metrics): prevent pgrst_db_pool_available drifting below zero#4630nothankyouzzz wants to merge 2 commits intoPostgREST:mainfrom
nothankyouzzz wants to merge 2 commits intoPostgREST:mainfrom
Conversation
Collaborator
|
@nothankyouzzz no merge commits please, rebase your branch against |
Track pool availability by connection id and set gauge from absolute state. Add unit coverage for lifecycle transitions and bounds.
2a4b017 to
71525aa
Compare
Author
|
@develop7 done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgrst_db_pool_availablecould drift below zero under connection churn or unstable networks. This happens because the metric was updated using pure inc/dec deltas without tracking per-connection state, so events like Connecting→Terminated or Ready→InUse→Terminated can double-decrement or decrement without a prior increment.Fix
Track availability per connection id and set the gauge from the absolute state:
Issue
Testing
postgrest-lintpostgrest-stylepostgrest-check