feat: implement circuit breaker and emergency pause for all betting#340
Open
YahKazo wants to merge 1 commit intoPredictify-org:masterfrom
Open
feat: implement circuit breaker and emergency pause for all betting#340YahKazo wants to merge 1 commit intoPredictify-org:masterfrom
YahKazo wants to merge 1 commit intoPredictify-org:masterfrom
Conversation
- Add admin-only pause/unpause commands with configurable scope (BettingOnly/Full) - Implement PauseScope enum for flexible pause control - BettingOnly scope blocks betting (place_bet, place_bets) while allowing other operations - Full scope blocks all betting, event creation, and operations - Add configurable withdrawal permissions (allow_withdrawals flag) during pause - Guards on place_bet, place_bets, create_event, and withdraw operations - Return Error::CBOpen when operations blocked by circuit breaker state - Comprehensive error handling with CB* error codes (500-503) - Event emission for pause/unpause actions with admin, reason, scope tracking - Add integration test test_pause_blocks_betting_and_unpause_restores() - Security: Admin-only access enforced via AdminAccessControl with 'emergency_actions' permission - Persist pause state in CircuitBreakerState with pause_scope and allow_withdrawals fields - Complete documentation in CIRCUIT_BREAKER_IMPLEMENTATION.md This implementation provides production-ready emergency pause functionality allowing admins to quickly pause betting or all operations during security incidents or emergencies, with granular control over which operations are blocked and whether withdrawals are permitted during pause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation provides production-ready emergency pause functionality allowing admins to quickly pause betting or all operations during security incidents or emergencies, with granular control over which operations are blocked and whether withdrawals are permitted during pause.
Pull Request Description
📋 Basic Information closes #301
Type of Change
Please select the type of change this PR introduces:
Related Issues
Closes #(issue number)
Fixes #(issue number)
Related to #(issue number)
Priority Level
📝 Detailed Description
What does this PR do?
Why is this change needed?
How was this tested?
Alternative Solutions Considered
🏗️ Smart Contract Specific
Contract Changes
Please check all that apply:
Oracle Integration
Market Resolution Logic
Security Considerations
🧪 Testing
Test Coverage
Test Results
Manual Testing Steps
📚 Documentation
Documentation Updates
Breaking Changes
Breaking Changes:
Migration Guide:
🔍 Code Quality
Code Review Checklist
Performance Impact
Security Review
🚀 Deployment & Integration
Deployment Notes
Integration Points
📊 Impact Assessment
User Impact
Business Impact
✅ Final Checklist
Pre-Submission
Review Readiness
📸 Screenshots (if applicable)
🔗 Additional Resources
💬 Notes for Reviewers
Please pay special attention to:
Questions for reviewers:
Thank you for your contribution to Predictify! 🚀