fix order creation on PrestaShop V9#12
fix order creation on PrestaShop V9#12matthieu-rolland wants to merge 1 commit intoPrestaShop:mainfrom
Conversation
| // Because we could be in CLI mode, there might be no employee in context, so we must set it manually | ||
| $context = Context::getContext(); | ||
| if (!isset($context->employee) || !isset($context->employee->id)) { | ||
| $context->employee = new Employee(1); | ||
| } |
There was a problem hiding this comment.
| // Because we could be in CLI mode, there might be no employee in context, so we must set it manually | |
| $context = Context::getContext(); | |
| if (!isset($context->employee) || !isset($context->employee->id)) { | |
| $context->employee = new Employee(1); | |
| } |
This service is not related to the context, and even less about its initialisation It shouldn't be its responsibility to init the legacy context
There was a problem hiding this comment.
We have a useful tool for that, not very well known or used, that allows the Symfony command to initialize the context instead:
https://github.com/PrestaShop/PrestaShop/blob/d68bfe619ea9ef8e9d57e96ce817028c68f3b885/tests/Integration/PrestaShopBundle/Command/LoadLegacyClassesinCommandTest.php#L123-L124
There was a problem hiding this comment.
@matks when using the tool suggested by @jolelievre I saw that it was broken for this use case, so I made a fix on the core
I need this PR to be merged first: PrestaShop/PrestaShop#36358, it's waiting for qa dev
3 participants
php bin/console prestashop:shop-creator --orders=10