Release v7.0.1 #205
Merged
Release v7.0.1 #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jolelievre
commented
Nov 29, 2024
jolelievre
commented
| Questions | Answers |
|---|---|
| Description? | Release v7.0.1 |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | ~ |
| How to test? | ~ |
Add nullable types for PHP 8.4 compatibility
nicosomb
approved these changes
Nov 29, 2024
tleon
approved these changes
Nov 29, 2024
florine2623
approved these changes
Nov 29, 2024
Contributor
florine2623
left a comment
florine2623
left a comment
There was a problem hiding this comment.
Hello @jolelievre ,
Tested with PS 9.0.0 and PHP 8.1, 8.2 and 8.3. Not tested with PHP 8.4.
Upgrade went well :
I noticed a missing letter :
# The 8.4 compatibility is not available yet, this should be uncommented whe the dockers are ready
-> when the dockers are ready
Tested the standard case.
CRUD list, add custom content,
Sort by ID, name of the block, position (and re-order).
LGTM ✅
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.