Skip to content

Conversation

@Codencode
Copy link
Contributor

Questions Answers
Description? This PR correctly sets the position to 0 when creating a new block (previously it was set to 1) and also assigns the position during update for shops that were not previously associated.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#36524
How to test? Case 1:
1. Create a new link block.
2. Check the position displayed in the list — it should be 1 and not 2.
(See #36524 for more details.)

Case 2:
1. Enable Multistore and create a second shop.
2. Create two link blocks, associating them with only one shop.
3. Edit both link blocks and associate them also with the other shop.
4. Verify that the positions are correctly assigned for each shop.

@ps-jarvis
Copy link

Hello @Codencode!

This is your first pull request on ps_linklist repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Nov 3, 2025
@Codencode Codencode requested a review from a team November 6, 2025 10:51
@SiraDIOP SiraDIOP self-assigned this Nov 14, 2025
@SiraDIOP
Copy link

Hello @Codencode,

Thanks for your PR, I tested and it'd good for me
Capture d’écran 2025-11-14 à 18 44 19

@SiraDIOP SiraDIOP added QA ✔️ Status: QA-Approved and removed Waiting for QA labels Nov 14, 2025
@Codencode Codencode merged commit dc152b3 into PrestaShop:dev Nov 14, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from To be tested to Merged in PR Dashboard Nov 14, 2025
@ps-jarvis
Copy link

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.

@Codencode Codencode deleted the fix-36524-BO-linklist---Position-ID-starts-from-2-instead-of-1 branch November 14, 2025 17:53
@Codencode Codencode added this to the 7.0.2 milestone Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA ✔️ Status: QA-Approved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

BO > linklist - Position ID starts from 2 instead of 1

4 participants