Skip to content

Fix the link since the page migration#82

Merged
Hlavtox merged 7 commits intoPrestaShop:devfrom
Touxten:Touxten-patch-1
Oct 30, 2025
Merged

Fix the link since the page migration#82
Hlavtox merged 7 commits intoPrestaShop:devfrom
Touxten:Touxten-patch-1

Conversation

@Touxten
Copy link
Contributor

@Touxten Touxten commented Jul 24, 2025

Questions Answers
Description? Fix the link from the page migration?
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? PrestaShop/PrestaShop#39185
Sponsor company @Touxten
How to test? Use Nginx ( not apache ) and test all the buttons on the module.

@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Jul 24, 2025
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$this->context->link->getAdminLink('AdminModules', true)

@Hlavtox Hlavtox added this to the 2.3.5 milestone Jul 25, 2025
@Touxten
Copy link
Contributor Author

Touxten commented Jul 25, 2025

It's done @Hlavtox

I don't quite understand this file, There are four calls with false as a parameter.

@Hlavtox
Copy link
Contributor

Hlavtox commented Jul 25, 2025

@Touxten Thanks!

I think that it's false because the token is assigned via $helper->token = Tools::getAdminTokenLite('AdminModules');, that's why the submit URL doesn't need it.

Hlavtox
Hlavtox previously approved these changes Jul 25, 2025
@Touxten
Copy link
Contributor Author

Touxten commented Jul 25, 2025

You are right

@ps-jarvis ps-jarvis moved this from Ready for review to Waiting for PM/UX/Dev in PR Dashboard Jul 28, 2025
Copy link

@SiraDIOP SiraDIOP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qa by Dev

@tleon
Copy link

tleon commented Oct 3, 2025

Why did you put that in QA by dev ? I think in the future we should have a reason why an issue is put in QA by dev

@Hlavtox
Copy link
Contributor

Hlavtox commented Oct 8, 2025

Ping @PrestaShop/qa-functional @PrestaShop/committers for QA, this is required for this module to work on 9.0.x branch on NGINX.

@kpodemski
Copy link
Contributor

kpodemski commented Oct 8, 2025

@Hlavtox If I recall correctly @Touxten managed to have it fixed with Nginx configuration change, could you confirm @Touxten ?

Codencode
Codencode previously approved these changes Oct 8, 2025
@nicosomb nicosomb modified the milestones: 2.3.5, 2.3.6 Oct 10, 2025
PoulainMaxime
PoulainMaxime previously approved these changes Oct 29, 2025
@SiraDIOP SiraDIOP self-assigned this Oct 30, 2025
Copy link

@SiraDIOP SiraDIOP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Touxten,
Thanks for your PR, it's fine with me. I tested it by following the instructions on how to test it.

However, the CI is red. Does that block the PR?

@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Oct 30, 2025

However, the CI is red. Does that block the PR?

If PHPStan (latest) is the only one failing, then it is fine to merge.

@Hlavtox Hlavtox merged commit cb5cfd7 into PrestaShop:dev Oct 30, 2025
15 of 24 checks passed
@github-project-automation github-project-automation bot moved this from Waiting for PM/UX/Dev to Merged in PR Dashboard Oct 30, 2025
@ps-jarvis ps-jarvis moved this from Merged to Waiting for PM/UX/Dev in PR Dashboard Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.