ENG-2736 - Remove Sandbox Unresponsive #337
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way that the prime cli handles "unresponsive" is not accurate. It is simply a timeout. Remove the concept of "unresponsive", and treat it as a timeout. If unresponsive sandboxes are an issue, the way to detect them would be with a liveliness checks and heartbeats.
Note
Simplifies sandbox timeout handling and removes the "unresponsive" concept.
SandboxUnresponsiveError(and its exports) and maps gateway timeouts toCommandTimeoutErrorin both sync/asyncexecute_commandeffective_timeout + 2s) to prevent premature client-side timeoutsprime-sandboxesto0.2.12Written by Cursor Bugbot for commit 64a2dff. This will update automatically on new commits. Configure here.