Skip to content

Conversation

@ericlau98
Copy link

@ericlau98 ericlau98 commented Dec 24, 2025

Summary

  • Add optional path argument to -s/--save-results flag in vf-eval
  • When path provided, results save to custom location instead of default ./outputs
  • Adds output_dir field to EvalConfig and updates path_utils.py

Usage

vf-eval gsm8k -s                 # save to default location
vf-eval gsm8k -s /custom/path    # save to custom location

Note

Enables saving eval outputs to a custom directory and adds a new RL config.

  • CLI: --save-results/-s now optionally accepts a PATH; without a path it behaves as a boolean flag. The chosen path is propagated as output_dir.
  • Plumb output_dir through the stack: add output_dir to EvalConfig, pass it from verifiers/scripts/eval.py, and make get_eval_results_path in verifiers/utils/path_utils.py honor it while preserving default ./outputs behavior.
  • Add configs/vf-rl/math-python.toml with env.id and run_name set to math-python.

Written by Cursor Bugbot for commit cd4c172. This will update automatically on new commits. Configure here.

Allow users to specify a custom output path via the -s/--save-results
flag. When a path is provided, results are saved there instead of
the default ./outputs or environment-local outputs directory.

Usage:
  vf-eval gsm8k -s              # default location
  vf-eval gsm8k -s /custom/path # custom location
@CLAassistant
Copy link

CLAassistant commented Dec 24, 2025

CLA assistant check
All committers have signed the CLA.

@ericlau98 ericlau98 changed the base branch from dev to main December 24, 2025 18:27
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config file references wrong environment ID

The math-python.toml configuration file sets id = "primeintellect/wiki-search" and run_name = "wiki-search", but it should reference the math-python environment instead. The environments/math_python/ directory exists with proper metadata indicating the environment ID is math-python. This appears to be a copy-paste error from another config file, causing the math-python config to load an entirely different environment when used.

configs/vf-rl/math-python.toml#L3-L4

[env]
id = "primeintellect/wiki-search"

configs/vf-rl/math-python.toml#L17-L18

[trainer.args]
run_name = "wiki-search"

Fix in Cursor Fix in Web


The config file had copy-paste errors referencing wiki-search instead
of math-python for both the environment ID and run_name.
@ericlau98 ericlau98 force-pushed the feat/custom-output-dir branch from 00d66a2 to cd4c172 Compare December 24, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants