Circular coil initialization with Splines #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@lazersos works well on my end. Thanks for contributing. One thing that could be improved. We can use |
Collaborator
Author
|
@zhucaoxiang This is pretty easy to implement. I'll make the modification and push the change. |
zhucaoxiang
approved these changes
Apr 14, 2025
Collaborator
zhucaoxiang
left a comment
zhucaoxiang
left a comment
There was a problem hiding this comment.
Looks good to me now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to initialize a run with circular coils using the spline representation. Additionally there were a few minor bugfixes regarding the length calcuations. There still may be issues with some metrics.