Skip to content

Fix issue #48 class Title and Html not found with mediawiki 1.44 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malberts merged 1 commit into from
Sep 24, 2025
Merged

Fix issue #48 class Title and Html not found with mediawiki 1.44 #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/JsonBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
use ModernTimeline\ResultFacade\SubjectCollection;
use ModernTimeline\SlidePresenter\SlidePresenter;
use SMWDITime;
use MediaWiki\Title\Title;
use MediaWiki\Html\Html;

class JsonBuilder {

Expand Down Expand Up @@ -54,8 +56,8 @@ public function buildEvent( Event $event ): array {
return $jsonEvent;
}

private function newHeadline( \Title $title ): string {
return \Html::element(
private function newHeadline( Title $title ): string {
return Html::element(
'a',
[ 'href' => $title->getFullURL() ],
$title->getText()
Expand Down
7 changes: 4 additions & 3 deletions src/TimelinePresenter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use ModernTimeline\SlidePresenter\SlidePresenter;
use ModernTimeline\SlidePresenter\TemplateSlidePresenter;
use SMWOutputs;
use MediaWiki\Html\Html;

class TimelinePresenter implements ResultPresenter {

Expand Down Expand Up @@ -61,7 +62,7 @@ private function getSlidePresenter( SimpleQueryResult $result ): SlidePresenter
}

private function createJs( string $json ): string {
return \Html::rawElement(
return Html::rawElement(
'script',
[
'type' => 'text/javascript'
Expand All @@ -75,14 +76,14 @@ private function createDiv( array $parameters ): string {
$width = $parameters[TimelineOptions::PARAM_WIDTH];
$height = $parameters[TimelineOptions::PARAM_HEIGHT];

return \Html::rawElement(
return Html::rawElement(
'div',
[
'id' => $this->id,
'style' => "width: $width; height: $height",
'class' => 'modern_timeline_outer_div'
],
\Html::element(
Html::element(
'div',
[
'class' => 'modern_timeline_inner_div',
Expand Down
Loading