Conversation
📝 WalkthroughWalkthroughCI matrix simplified (dropped older MW entries, consolidated REL1_43); PHP requirement raised to >=8.1; extension bumped to 3.0.0-dev and MediaWiki/SMW minimums raised to 1.43.0 and 6.0.0; README and composer examples updated accordingly. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (6)
composer.json (1)
35-38: Consider simplifying composer/installers constraintGiven the new minimums, you likely no longer need Composer Installers v1. Consider dropping support for
^1.0.1to reduce solver surface.Apply:
- "composer/installers": "^2|^1.0.1", + "composer/installers": "^2",README.md (3)
43-46: Fix markdownlint MD010: replace hard tabs with spaces in JSON blockUse spaces to satisfy no-hard-tabs.
-{ - "require": { - "professional-wiki/modern-timeline": "~3.0" - } -} +{ + "require": { + "professional-wiki/modern-timeline": "~3.0" + } +}
51-52: Fix markdownlint MD046: use fenced code block for the single-line snippetWrap the indented line in fences (and JSON hint).
- "professional-wiki/modern-timeline": "~3.0" +```json +"professional-wiki/modern-timeline": "~3.0" +```
173-182: Fix markdownlint MD034: avoid bare URL in release notesTurn the bare URL into a markdown link.
-* Translation updates from https://translatewiki.net +* Translation updates from [translatewiki.net](https://translatewiki.net).github/workflows/ci.yml (2)
16-36: Have at least one non-experimental gate in the matrixAll entries are
experimental: true, meaning the test job won’t fail the build on regressions. Make the stable REL1_43 + PHP 8.3 + MySQL job non-experimental to gate merges.- - mw: 'REL1_43' - php: '8.3' - db: 'mysql' - smw: 'dev-master' - experimental: true + - mw: 'REL1_43' + php: '8.3' + db: 'mysql' + smw: 'dev-master' + experimental: false
16-36: Pin actions and service images for supply-chain safetyPin GitHub Actions to SHAs and use a versioned MariaDB image to avoid unreviewed updates.
Example (apply across the workflow):
- actions/checkout@v4 → actions/checkout@
- actions/cache@v4 → actions/cache@
- shivammathur/setup-php@v2 → shivammathur/setup-php@
- codecov/codecov-action@v5 → codecov/codecov-action@
- services.db.image: mariadb → mariadb:10.11
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/ci.yml(1 hunks)README.md(3 hunks)composer.json(1 hunks)extension.json(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
43-43: Hard tabs
Column: 1
(MD010, no-hard-tabs)
44-44: Hard tabs
Column: 1
(MD010, no-hard-tabs)
51-51: Code block style
Expected: fenced; Actual: indented
(MD046, code-block-style)
181-181: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (4)
composer.json (1)
35-38: Aligns with platform bump to PHP 8.1The PHP constraint matches the rest of the PR (MW ≥1.43, SMW ≥5.0). Looks good.
README.md (1)
21-23: “Tested up to” is inconsistent with 1.44 supportRelease notes say 1.44 compat is fixed, yet the header says “tested up to 1.43”. Update if accurate.
Apply:
-* MediaWiki 1.43 or later (tested up to MediaWiki 1.43) +* MediaWiki 1.43 or later (tested up to MediaWiki 1.44)extension.json (2)
4-4: Version bump to 3.0.0-dev looks goodMatches README’s 3.0.0 section and the “drop old dependencies” objective.
21-26: Raised minimums to MW 1.43 and SMW 5.0 are appropriateConsistent with CI and README changes.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
README.md (4)
21-23: Align “tested up to” with 1.44 support claimRelease notes state 1.44 compatibility; suggest updating the tested note for consistency.
-* MediaWiki 1.43 or later (tested up to MediaWiki 1.43) +* MediaWiki 1.43 or later (tested up to MediaWiki 1.44)
40-46: Fix markdownlint MD010 and add JSON syntax highlightingReplace hard tabs with spaces and mark fence as JSON.
-``` +```json { - "require": { - "professional-wiki/modern-timeline": "~3.0" - } + "require": { + "professional-wiki/modern-timeline": "~3.0" + } }--- `50-52`: **Fix MD046: use fenced code block for the single-line snippet** Wrap the indented line in a fenced code block. ```diff - "professional-wiki/modern-timeline": "~3.0" +```json +"professional-wiki/modern-timeline": "~3.0" +```
181-181: Avoid bare URL (MD034)Use a markdown link.
-* Translation updates from https://translatewiki.net +* Translation updates from [translatewiki.net](https://translatewiki.net)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/ci.yml(1 hunks)README.md(3 hunks)composer.json(1 hunks)extension.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- .github/workflows/ci.yml
- extension.json
- composer.json
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
43-43: Hard tabs
Column: 1
(MD010, no-hard-tabs)
44-44: Hard tabs
Column: 1
(MD010, no-hard-tabs)
51-51: Code block style
Expected: fenced; Actual: indented
(MD046, code-block-style)
181-181: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (1)
README.md (1)
23-23: SMW 6.0 bump LGTMMatches prior suggestion in earlier review comments.
2 participants
Due to MW 1.44 support in #49.
CI has been failing for a while, so unrelated to this PR.
Summary by CodeRabbit