Skip to content

Conversation

@ilicfilip
Copy link
Collaborator

@ilicfilip ilicfilip commented Nov 3, 2025

This PR converts settings from Settings page to interactive tasks, as much as possible.

It is still WIP but set About, Contact and FAQ page settings are converted - the choices user has are the same:

  • I have this page
  • I dont have this page yet (Created this page)
  • My site doesnt need this page

All 3 tasks share same codebase, but we can adjust popover to recommend user to install Contact form or any other feature.

Things left to implement (from Slack discussion):

  • Detect if site has home page set and auto assign it (no need for user to do it) We already do this
  • Convert "Select the Valuable Post Types" to interactive task, it should reappear every time a new post type is added and/or removed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Test merged PR on Playground
Test this pull request on the Playground
or download the zip

@ilicfilip
Copy link
Collaborator Author

ilicfilip commented Nov 3, 2025

The "Set valuable post types" task is also converted to be interactive.

Task will be added again if the new public post type is detected. I think there is no need to add it when public post type is removed since that means there will just be one less checkbox to be selected, which doesn't give user any other option than confirming the current selection (also it might be confusing, if user doesn't realize that one post type is now missing).

Since "Set pages" and "Set valuable post types" are now interactive tasks the only option on that page is "Default login destination". If we move it to the PP dashboard page, maybe create a button (next to the Tour and Registration) which triggers popover with that option?

If we do that, should we remove Settings Page completely and "Fill the Settings Page" task as well?

EDIT:
There was an idea about implementing a way for user to check if our API is available ( #425 ), but it was never finished. I think it's a good thing to have, since we are increasingly dependent on our server, but we will need to find a new place for this if the Settings page is removed.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

✅ Code Coverage Report

Metric Value
Total Coverage 29.07% 📉
Base Coverage 29.55%
Difference 📉 -0.48%

⚠️ Coverage below recommended 40% threshold

📊 File-level Coverage Changes (7 files)

🆕 New Files

Class Coverage Lines
🔴 Progress_Planner\Suggested_Tasks\Providers\Set_Page_About 0.00% 0/7
🔴 Progress_Planner\Suggested_Tasks\Providers\Set_Page_Contact 0.00% 0/7
🔴 Progress_Planner\Suggested_Tasks\Providers\Set_Page_FAQ 0.00% 0/7
🔴 Progress_Planner\Suggested_Tasks\Providers\Set_Page_Task 0.00% 0/58

📈 Coverage Improved

Class Before After Change
Progress_Planner\Admin\Page 28.18% 30.54% +2.36%
Progress_Planner\Suggested_Tasks\Tasks_Manager 65.77% 66.37% +0.60%

📉 Coverage Decreased

Class Before After Change
Progress_Planner\Admin\Page_Settings 15.29% 4.62% -10.67%
ℹ️ About this report
  • All tests run in a single job with Xdebug coverage
  • Security tests excluded from coverage to prevent output issues
  • Coverage calculated from line coverage percentages

@ilicfilip ilicfilip marked this pull request as ready for review December 12, 2025 14:14
@aristath
Copy link
Member

@ilicfilip In this PR we need to:

  1. Remove the admin page
  2. Remove the task to fill-in the settings page.

Once these get added, this will be ready to merge 👍 🥇

@aristath aristath merged commit 7ef39be into develop Dec 15, 2025
30 checks passed
@aristath aristath deleted the filip/v110/page-interactive-tasks branch December 15, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants