Split default configs across multiple files#17
Draft
m4u9 wants to merge 5 commits intoProjectGreybeard:mainfrom
Draft
Split default configs across multiple files#17m4u9 wants to merge 5 commits intoProjectGreybeard:mainfrom
m4u9 wants to merge 5 commits intoProjectGreybeard:mainfrom
Conversation
|
Why 90? Isn’t it making it too much difficult for users for their own modifications? |
mcepl
reviewed
Feb 2, 2024
| # and edit it to your liking. | ||
|
|
||
| include /etc/sway/config.d/*.conf | ||
| include ~/.config/sway/config.d/* |
There was a problem hiding this comment.
Firstly, I hugely prefer
include ~/.config/sway/config.d/*.conf
meaning that the user can deactivate some parts of configuration by adding another file extension.
Additionally, I find useful (as the last line) to have also:
include ~/.config/sway/config.$(hostname)/*.confto have unified configuration (good for git etc.) for multiple machines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to split the default configs across multiple config files that can make things easier for users to override and tune.
The idea is to have the default configs as 90-foo.config files in /etc/sway/config.d/ and users can copy them to $HOME/.config/sway/config.d/ to be edited as needed.
Default config files are split in /etc/sway/config.d as follow:
To override a setting, the new file should be named with a lower integer in the filename. For example 10-appearance.conf would override the provided 90-appearance.conf.
The setup should be properly documented in the *.conf files as comments as well as in the OS documentation when available.
I marked this PR as draft as an effort to gather some feedbacks first. There are other changes in other open PRs not yet implemented here and will need to be added if merged.