Draft
Conversation
mvahowe
reviewed
Jul 29, 2022
Contributor
mvahowe
left a comment
mvahowe
left a comment
There was a problem hiding this comment.
This looks good! I merged main, fixed a comment and made a few changes so that the graph displays full screen. (Hit the G button).
There's an error about not giving a size for the graph component, which the linked fix doesn't seem to fix, and the Github CI checks fail, so we should probably investigate some more before merging.
Please do the demo from this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is probably sometimes useful to just have a view of the graphical visual representation - even without the interactive features
(interactivity is supported by React Flow, so this can potentially be added later...)