Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

Add, edit and send embedded images#51

Draft
Swiip wants to merge 1 commit intomasterfrom
feat/embedded-images
Draft

Add, edit and send embedded images#51
Swiip wants to merge 1 commit intomasterfrom
feat/embedded-images

Conversation

@Swiip
Copy link
Contributor

@Swiip Swiip commented Jan 31, 2020 •
edited
Loading

Features

  • Custom Quill toolbar
  • Custom Quill image component
  • New embedded content modal
  • Pseudo modal to choose between image inline or attachment
  • Drop file on the composer
  • New message processing chain for saving and sending
  • Send message with embedded content in HTML format
  • Send message with embedded content in MIME format

Refacto

  • Update to new crypto typings
  • Rename MessageExtended documents properties for both rendering and exporting
  • Remove MessageExtended content (replace by document*.innerHTML)
  • Create an AttachmentProvider, replace local caches for embedded blob and cids

Fixes

  • Parse and mutate content correctly to save and send
  • Add class and attribute to embedded image
  • Fix crypto key management draft creation
  • Fix url validation at modal opening
  • Fix embedded elements positioning between saving and re-loading

@Swiip Swiip changed the title Early version with embedded image Add, edit and send embedded images Jan 31, 2020
@Swiip Swiip self-assigned this Jan 31, 2020
@Swiip Swiip force-pushed the feat/embedded-images branch from 853bfcf to 6cacd28 Compare February 3, 2020 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@Swiip Swiip

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Swiip