Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

Fix isUTC and UTC timezone#116

Draft
mmso wants to merge 2 commits intomasterfrom
fix/vcal-utc
Draft

Fix isUTC and UTC timezone#116
mmso wants to merge 2 commits intomasterfrom
fix/vcal-utc

Conversation

@mmso
Copy link
Member

@mmso mmso commented Jan 29, 2020

Turns out that

BEGIN:VEVENT
DTSTART;TZID=Etc/UTC:20190101T000000
DTEND;TZID=UTC:20190101T020000
END:VEVENT

Would get parsed as:

{
            component: 'vevent',
            dtstart: {
                value: { year: 2019, month: 1, day: 1, hours: 0, minutes: 0, seconds: 0, isUTC: false },
                parameters: { tzid: 'Etc/UTC' }
            },
            dtend: {
                value: { year: 2019, month: 1, day: 1, hours: 2, minutes: 0, seconds: 0, isUTC: true },
                parameters: { tzid: 'UTC' }
            }
        }

Which would make some of the places were we're checking !tzid unneccessarily convert UTC to UTC. Not sure if this PR is worth it.

@mmso mmso requested a review from econdepe January 29, 2020 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant