Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

Focus dropdown#314

Open
Yiin wants to merge 1 commit intomasterfrom
feat/focus-via-keyboard-on-dropdown
Open

Focus dropdown#314
Yiin wants to merge 1 commit intomasterfrom
feat/focus-via-keyboard-on-dropdown

Conversation

@Yiin
Copy link
Contributor

@Yiin Yiin commented Sep 30, 2019

@Yiin Yiin requested a review from vincaslt September 30, 2019 08:43
Copy link
Contributor

@vincaslt vincaslt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it work fine with modals and tooltips?

@mmso
Copy link
Member

mmso commented Sep 30, 2019

Where does focus end up after closing the dropdown? Is the user able to tab to the next focusable element?

@nico3333fr
Copy link
Contributor

nico3333fr commented Sep 30, 2019

If we focus back using Maj+tab, do the focus comes back to previous element ?

@mmso
Copy link
Member

mmso commented Sep 30, 2019

I am starting to think it was perhaps a mistake to move dropdowns into absolutely positioned elements. It did solve the overflow problem, but I feel like it may have caused more problems than it solved. Perhaps we could have solved the overflow problem in another way.

@vincaslt
Copy link
Contributor

vincaslt commented Oct 1, 2019

I agree... It seems to solve the problem in basic cases, but is pretty hard to ensure it works with all the custom stuff we have - modals, non-body scroll containers (especially multiple).

I would like to have this solved in css if possible (from my knowledge it's not doable, unless something new was added that made it possible) or use some 3rd party that handles this for us and tries to catch the edge cases, like https://popper.js.org/ (not sure if it wouldn't run into the same problems that we have now)

@mmso mmso added the Blocked label Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Focus via keyboard doesn't work with the dropdwon

4 participants