Conversation
vincaslt
left a comment
There was a problem hiding this comment.
does it work fine with modals and tooltips?
|
Where does focus end up after closing the dropdown? Is the user able to tab to the next focusable element? |
|
If we focus back using Maj+tab, do the focus comes back to previous element ? |
|
I am starting to think it was perhaps a mistake to move dropdowns into absolutely positioned elements. It did solve the overflow problem, but I feel like it may have caused more problems than it solved. Perhaps we could have solved the overflow problem in another way. |
|
I agree... It seems to solve the problem in basic cases, but is pretty hard to ensure it works with all the custom stuff we have - modals, non-body scroll containers (especially multiple). I would like to have this solved in css if possible (from my knowledge it's not doable, unless something new was added that made it possible) or use some 3rd party that handles this for us and tries to catch the edge cases, like https://popper.js.org/ (not sure if it wouldn't run into the same problems that we have now) |
Fixes https://github.com/ProtonMail/react-components/issues/303