This repository was archived by the owner on Aug 11, 2021. It is now read-only.
Open
Conversation
Contributor
|
Hi @robsel118 Thanks a lot for your pull request. Your code looks good but we would like to improve it a bit:
|
Author
|
Hello @EpokK , sorry for the delay. <Dropzone
onDrop={file => console.log(file)}
onDragEnter={isFileValid => {
if (isFileValid) {
console.log('success');
} else {
console.log('failure');
}
}}
onDragExit={() => console.log('file was not dropped')}
validTypes={[
'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
'text/x-vcard'
]}
>
<div>DROP ZONE</div>
</Dropzone> |
…nged to proton colors
Yiin
suggested changes
Oct 22, 2019
Yiin
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#139
I have tried to make a basic dropzone. If I could access the Zeplin mock-up, I could see to change it a bit. When dropping a valid file, the
handleDropcallback function is called with the file.All the children are rendered in a centered column.
Please let me know of any issues and improvements.
Example