Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

WIP: Add lazy loader for translations#542

Open
dhoko wants to merge 1 commit intomasterfrom
feat/auto-load-i18n
Open

WIP: Add lazy loader for translations#542
dhoko wants to merge 1 commit intomasterfrom
feat/auto-load-i18n

Conversation

@dhoko
Copy link
Contributor

@dhoko dhoko commented Jan 27, 2020

  • Add fix inside proton-pack to prevent error if we do not have the dependency.
  • Add repository

Short description of what this resolves:

cf ProtonMail/proton-mail-settings#281
We won't commit locales anymore, instead they are going to come as dependencies.

ℹ️ if we do not have locales it won't load anything not break the app

Changes proposed in this pull request:

  • Move the lazy loader here so we can share it

@dhoko dhoko force-pushed the feat/auto-load-i18n branch from 705ede5 to 87d97cd Compare January 27, 2020 11:48
@dhoko dhoko force-pushed the feat/auto-load-i18n branch from 87d97cd to cf77784 Compare January 27, 2020 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant